From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6bj9-0007fR-7C for qemu-devel@nongnu.org; Tue, 06 Aug 2013 03:30:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V6bj3-0007PU-Pb for qemu-devel@nongnu.org; Tue, 06 Aug 2013 03:30:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6bj3-0007PN-Gi for qemu-devel@nongnu.org; Tue, 06 Aug 2013 03:30:37 -0400 From: Markus Armbruster References: <1375626131-6857-1-git-send-email-afaerber@suse.de> Date: Tue, 06 Aug 2013 09:30:15 +0200 In-Reply-To: <1375626131-6857-1-git-send-email-afaerber@suse.de> ("Andreas =?utf-8?Q?F=C3=A4rber=22's?= message of "Sun, 4 Aug 2013 16:22:06 +0200") Message-ID: <878v0f1dko.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-next for-next 0/5] QOM PCMCIA, MicroDrive and IDE cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: Kevin Wolf , Othmar Pasteka , qemu-devel@nongnu.org, Anthony Liguori , Peter Maydell Andreas F=C3=A4rber writes: > Hello, > > Based on an initial draft from Othmar Pasteka, this series QOM'ifies Micr= oDrive. > As a prerequisite, PCMCIA must be QOM'ified as pointed out by Peter. We c= an then > finally drop ide_init2_with_non_qdev_drives(), as desired by Markus for h= is > IDE refactorings. As a final touch, pxa2xx_pcmcia is made a SysBusDevice. Full IDE qdevification achieved in just under four years (assuming we get this committed before September 15). I'm tickled pink. Thanks a lot for making this happen! To Othmar, too, of course. > A for-1.6 patch to fix an assertion while inspecting the QOM composition = tree > was sent out separately. > > QOM'ifying the PXA2xx SoCs to replace pxa2xx_pcmcia_init() and other help= ers > is left as follow-up. > > We probably also want to move "info pcmcia" HMP out of vl.c but I'm not s= ure > in which form we want to keep PCMCIASocket? A SysBusDevice subtype would = seem > easiest for our current use case, but there are also PCI-CardBus bridges = IIRC. > PCMCIASocket::card_string should probably be a property of PCMCIACardStat= e, > accessed through a link property. > > Markus, unfortunately git am --3way didn't work for your old IDE patches. > Please rebase them on this series yourself, thanks. Sure!