From: Kevin Hilman <khilman@linaro.org>
To: Thomas Meyer <thomas@m3y3r.de>
Cc: tony@atomide.com, linux@arm.linux.org.uk,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP: Cocci spatch "ptr_ret.spatch"
Date: Mon, 03 Jun 2013 14:17:50 -0700 [thread overview]
Message-ID: <878v2qlwqp.fsf@linaro.org> (raw)
In-Reply-To: <1370079884.29224.16.camel@localhost.localdomain> (Thomas Meyer's message of "Sat, 01 Jun 2013 11:44:44 +0200")
Thomas Meyer <thomas@m3y3r.de> writes:
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Could use a changelog, but otherwise
Acked-by: Kevin Hilman <khilman@linaro.org>
> ---
>
> diff -u -p a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -66,7 +66,7 @@ static int __init omap3_l3_init(void)
>
> WARN(IS_ERR(pdev), "could not build omap_device for %s\n", oh_name);
>
> - return IS_ERR(pdev) ? PTR_ERR(pdev) : 0;
> + return PTR_RET(pdev);
> }
> omap_postcore_initcall(omap3_l3_init);
>
> @@ -100,7 +100,7 @@ static int __init omap4_l3_init(void)
>
> WARN(IS_ERR(pdev), "could not build omap_device for %s\n", oh_name);
>
> - return IS_ERR(pdev) ? PTR_ERR(pdev) : 0;
> + return PTR_RET(pdev);
> }
> omap_postcore_initcall(omap4_l3_init);
>
> diff -u -p a/arch/arm/mach-omap2/fb.c b/arch/arm/mach-omap2/fb.c
> --- a/arch/arm/mach-omap2/fb.c
> +++ b/arch/arm/mach-omap2/fb.c
> @@ -83,10 +83,7 @@ static int __init omap_init_vrfb(void)
> pdev = platform_device_register_resndata(NULL, "omapvrfb", -1,
> res, num_res, NULL, 0);
>
> - if (IS_ERR(pdev))
> - return PTR_ERR(pdev);
> - else
> - return 0;
> + return PTR_RET(pdev);
> }
>
> omap_arch_initcall(omap_init_vrfb);
> diff -u -p a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
> --- a/arch/arm/mach-omap2/gpmc.c
> +++ b/arch/arm/mach-omap2/gpmc.c
> @@ -1678,7 +1678,7 @@ static int __init omap_gpmc_init(void)
> pdev = omap_device_build(DEVICE_NAME, -1, oh, NULL, 0);
> WARN(IS_ERR(pdev), "could not build omap_device for %s\n", oh_name);
>
> - return IS_ERR(pdev) ? PTR_ERR(pdev) : 0;
> + return PTR_RET(pdev);
> }
> omap_postcore_initcall(omap_gpmc_init);
>
> diff -u -p a/arch/arm/mach-omap2/pmu.c b/arch/arm/mach-omap2/pmu.c
> --- a/arch/arm/mach-omap2/pmu.c
> +++ b/arch/arm/mach-omap2/pmu.c
> @@ -54,10 +54,7 @@ static int __init omap2_init_pmu(unsigne
> WARN(IS_ERR(omap_pmu_dev), "Can't build omap_device for %s.\n",
> dev_name);
>
> - if (IS_ERR(omap_pmu_dev))
> - return PTR_ERR(omap_pmu_dev);
> -
> - return 0;
> + return PTR_RET(omap_pmu_dev);
> }
>
> static int __init omap_init_pmu(void)
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2013-06-03 21:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 9:44 [PATCH] ARM: OMAP: Cocci spatch "ptr_ret.spatch" Thomas Meyer
2013-06-03 21:17 ` Kevin Hilman [this message]
2013-07-04 11:48 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878v2qlwqp.fsf@linaro.org \
--to=khilman@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=thomas@m3y3r.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.