[ath9k-devel] [RFC/RFT 1/2] ath10k: WMI add AP PS

[Kalle Valo <kvalo@qca.qualcomm.com>]

Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:

> Add AP power save (UAPSD) structures, enums.
>
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
> ---
>  drivers/net/wireless/ath/ath10k/wmi.c |   26 +++++++++++++
>  drivers/net/wireless/ath/ath10k/wmi.h |   67 +++++++++++++++++++++++++++++++++
>  2 files changed, 93 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
> index 5272f18..453138b 100644
> --- a/drivers/net/wireless/ath/ath10k/wmi.c
> +++ b/drivers/net/wireless/ath/ath10k/wmi.c
> @@ -1850,6 +1850,32 @@ int ath10k_wmi_set_sta_ps_param(struct ath10k *ar, u32 vdev_id,
>  	return ath10k_wmi_cmd_send(ar, skb, WMI_STA_POWERSAVE_PARAM_CMDID);
>  }
>  
> +int ath10k_wmi_set_ap_ps_param(struct ath10k *ar, u32 vdev_id, const u8 *mac,
> +			       enum wmi_ap_ps_peer_param param_id, u32 value)
> +{

[...]

> +	cmd->vdev_id     = __cpu_to_le32(vdev_id);
> +	cmd->param_id    = __cpu_to_le32(param_id);
> +	cmd->param_value = __cpu_to_le32(value);

No extra whitespace before '='.

> +	memcpy(&cmd->peer_macaddr, mac, ETH_ALEN);
> +
> +	ath10k_dbg(ATH10K_DBG_WMI,
> +		   "wmi ap ps param vdev_id 0x%X param %d value %d "
> +		   "mac_addr %pM\n", vdev_id, param_id, value, mac);

Don't split the format string into two. The long line limit doesn't
apply to logging format strings.

> diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h
> index 9946a51..b9f5b62 100644
> --- a/drivers/net/wireless/ath/ath10k/wmi.h
> +++ b/drivers/net/wireless/ath/ath10k/wmi.h
> @@ -2397,6 +2397,71 @@ struct wmi_sta_mimo_ps_mode_cmd {
>  	__le32 mimo_pwrsave_mode;
>  } __packed;
>  
> +

Extra empty line.

> +/* U-APSD maximum service period of peer station */
> +enum wmi_ap_ps_peer_param_max_sp {
> +	WMI_AP_PS_PEER_PARAM_MAX_SP_UNLIMITED = 0,
> +	WMI_AP_PS_PEER_PARAM_MAX_SP_2 = 1,
> +	WMI_AP_PS_PEER_PARAM_MAX_SP_4 = 2,
> +	WMI_AP_PS_PEER_PARAM_MAX_SP_6 = 3,
> +	/* keep last! */

Empty line before the comment.

> +struct wmi_ap_ps_peer_cmd {
> +	/** unique id identifying the VDEV, generated by the caller */
> +	__le32 vdev_id;
> +	/** peer MAC address */
> +	struct wmi_mac_addr peer_macaddr;
> +	/** AP powersave param (see enum wmi_ap_ps_peer_param) */
> +	__le32 param_id;
> +	/** AP powersave param value */
> +	__le32 param_value;
> +} __packed;

Empty line before the comments, except the first one.

Also there are new warnings:

drivers/net/wireless/ath/ath10k/wmi.h:2494: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/wmi.h:2514: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/wmi.c:1924: CHECK: No space is necessary after a cast
drivers/net/wireless/ath/ath10k/mac.c:906: CHECK: Blank lines aren't necessary after an open brace '{'
drivers/net/wireless/ath/ath10k/mac.c:908: WARNING: quoted string split across lines
drivers/net/wireless/ath/ath10k/mac.c:913: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/mac.c:916: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/mac.c:919: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/mac.c:922: WARNING: line over 80 characters

-- 
Kalle Valo