From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPWiF-0000YP-Nd for qemu-devel@nongnu.org; Tue, 09 Apr 2013 07:27:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPWiE-0001Yd-M7 for qemu-devel@nongnu.org; Tue, 09 Apr 2013 07:27:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30777) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPWiE-0001YZ-EX for qemu-devel@nongnu.org; Tue, 09 Apr 2013 07:27:42 -0400 From: Markus Armbruster References: <1365418028-2546-1-git-send-email-pbonzini@redhat.com> <87ip3wm6g1.fsf@blackfin.pond.sub.org> <5163D7A4.6080001@redhat.com> Date: Tue, 09 Apr 2013 13:27:36 +0200 In-Reply-To: <5163D7A4.6080001@redhat.com> (Paolo Bonzini's message of "Tue, 09 Apr 2013 10:56:04 +0200") Message-ID: <878v4sj653.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] migration: initialize RAM to zero List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, aliguori@us.ibm.com, quintela@redhat.com, stefanha@gmail.com, pl@kamp.de, qemu-devel@nongnu.org, owasserm@redhat.com Paolo Bonzini writes: > Il 09/04/2013 10:52, Markus Armbruster ha scritto: >>> > This also removes the need to do something special on valgrind >>> > (see commit c2a8238a, Support running QEMU on Valgrind, 2011-10-31). >> Suggest to state explicitly that you effectively revert it. >> >> You left #define CONFIG_VALGRIND in, even though it's no longer used. >> Intentional? > > Oh, there's both CONFIG_VALGRIND and CONFIG_VALGRIND_H. Nice. I'll > send v2. That confused me briefly, too :) Make sure to address the mmap() error checking as well.