From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH 2/2] drm/i915/sdvo: restore i2c adapter
	config on intel_sdvo_init() failures
Date: Fri, 26 Oct 2012 09:21:05 +0300
Message-ID: <878vatu52m.fsf@intel.com>
References: <1f94a8e4fd02189024f71dddcc69e60a2225498c.1350911444.git.jani.nikula@intel.com>
	<51e603fa921dec2b137d759a86c6169d26b461be.1350911444.git.jani.nikula@intel.com>
	<275ffc$73rhq3@fmsmga002.fm.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
	by gabe.freedesktop.org (Postfix) with ESMTP id 5AEB49E82A
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 26 Oct 2012 07:48:09 -0700 (PDT)
In-Reply-To: <275ffc$73rhq3@fmsmga002.fm.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, 23 Oct 2012, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Mon, 22 Oct 2012 16:12:18 +0300, Jani Nikula <jani.nikula@intel.com> wrote:
>> SDVOB may be multiplexed with HDMIB. If it's not SDVOB, the same i2c
>> adapter may be used for HDMIB, with the adjusted config (i.e. with GPIO
>> bit-banging instead of gmbus). Restore i2c adapter config before error
>> return from intel_sdvo_init(), letting HDMIB enjoy the joys of gmbus.
>
> I would personally not make the assumption that set_speed has no effect.
> Disabling GMBUS is a hack that we should eventually lift.

I guess this comment was more about the whole, not just patch 2/2, but
Daniel merged 1/2 already. IIUC you would have wanted to keep set_speed
there, but shall we just leave that to when we start using GMBUS on
SDVO? Patch 2/2 is pretty straightforward, but will also need some love
when enabling GMBUS.

Thoughts?

BR,
Jani.