All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH resend] Added protobuf package
Date: Thu, 05 Apr 2012 19:50:31 +0200	[thread overview]
Message-ID: <878viarrtk.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <CAHt8ZCMdK6Stia58eSVenoUqJHBDQ0Aptx_yWedvGRD-F8O8XQ@mail.gmail.com> (Simon Dawson's message of "Thu, 15 Mar 2012 08:51:27 +0000")

>>>>> "Simon" == Simon Dawson <spdawson@gmail.com> writes:

 Simon> Signed-off-by: Simon Dawson <spdawson@gmail.com>
 Simon> ---
 Simon>  package/Config.in            |    1 +
 Simon>  package/protobuf/Config.in   |    7 +++++++
 Simon>  package/protobuf/protobuf.mk |   17 +++++++++++++++++
 Simon>  3 files changed, 25 insertions(+), 0 deletions(-)
 Simon>  create mode 100644 package/protobuf/Config.in
 Simon>  create mode 100644 package/protobuf/protobuf.mk

 Simon> diff --git a/package/Config.in b/package/Config.in
 Simon> index 36a221c..575373a 100644
 Simon> --- a/package/Config.in
 Simon> +++ b/package/Config.in
 Simon> @@ -388,6 +388,7 @@ source "package/liburcu/Config.in"
 Simon>  source "package/lttng-libust/Config.in"
 Simon>  source "package/orc/Config.in"
 Simon>  source "package/poco/Config.in"
 Simon> +source "package/protobuf/Config.in"
 Simon>  source "package/startup-notification/Config.in"
 Simon>  endmenu

 Simon> diff --git a/package/protobuf/Config.in b/package/protobuf/Config.in
 Simon> new file mode 100644
 Simon> index 0000000..1b0085b
 Simon> --- /dev/null
 Simon> +++ b/package/protobuf/Config.in
 Simon> @@ -0,0 +1,7 @@
 Simon> +config BR2_PACKAGE_PROTOBUF
 Simon> +       bool "protobuf"
 Simon> +       help
 Simon> +         Protocol buffers are Google's language-neutral, platform-neutral,

These lines should be indented with <tab> and not spaces (help lines
with <tab><space><space>)

Protobuf is implemented in C++, so it should depend on
BR2_INSTALL_LIBSTDCPP.

 Simon> +# N.B. Need to use host protoc during cross compilation.
 Simon> +PROTOBUF_DEPENDENCIES = host-protobuf
 Simon> +PROTOBUF_CONF_OPT = --with-protoc=$(HOST_DIR)/usr/bin/protoc
 Simon> +
 Simon> +PROTOBUF_INSTALL_STAGING = YES
 Simon> +

protobuf can use zlib, so we need to ensure it gets built after it if
enabled.

Committed with those fixes, thanks.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2012-04-05 17:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-15  8:51 [Buildroot] [PATCH resend] Added protobuf package Simon Dawson
2012-04-05 17:50 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878viarrtk.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.