From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] gst-plugins-base: add option to select 'alsa'
Date: Sat, 11 Feb 2012 17:58:49 +0100 [thread overview]
Message-ID: <878vk91f3q.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <201202111705.26348.arnout@mind.be> (Arnout Vandecappelle's message of "Sat, 11 Feb 2012 17:05:26 +0100")
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
Hi,
Arnout> Keep the config options ordered alphabetically, so put it before OGG.
Arnout> Also, if the option exists, it should be used in the mk-file. So add:
Arnout> ifeq ($(BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_ALSA),y)
Arnout> GST_PLUGINS_BASE_CONF_OPT += --enable-alsa
Arnout> else
Arnout> GST_PLUGINS_BASE_CONF_OPT += --disable-alsa
Arnout> endif
Indeed, people expect to be able to disable that option and not have the
alsa plugin built.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2012-02-11 16:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-11 0:04 [Buildroot] [PATCH 0/3] Random updates Felipe Contreras
2012-02-11 0:04 ` [Buildroot] [PATCH 1/3] gst-dsp: add dependency to pkg-config Felipe Contreras
2012-02-11 14:42 ` Peter Korsgaard
2012-02-11 0:04 ` [Buildroot] [PATCH 2/3] gst-plugins-base: add option to select 'alsa' Felipe Contreras
2012-02-11 16:05 ` Arnout Vandecappelle
2012-02-11 16:58 ` Peter Korsgaard [this message]
2012-02-11 0:04 ` [Buildroot] [PATCH 3/3] .gitignore: remove wrong entries Felipe Contreras
2012-02-11 16:12 ` Arnout Vandecappelle
2012-02-11 17:27 ` Felipe Contreras
[not found] ` <CAAXf6LXsQCsdwswHGa=Ei-+DkB7OyJbKnz7MhatTeEgCk5MMWw@mail.gmail.com>
2012-02-11 23:01 ` Felipe Contreras
2012-02-12 11:05 ` Arnout Vandecappelle
2012-02-13 19:40 ` Felipe Contreras
2012-02-14 9:50 ` Thomas De Schampheleire
[not found] ` <CAAXf6LVq7X9-W7syJKUyaz+VyC3+tzGq6A4XMz96ZUqsrR77=w@mail.gmail.com>
2012-02-14 12:37 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vk91f3q.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.