All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH] configure: ignore spice libraries on 32 bit.
Date: Wed, 08 Feb 2012 10:47:23 +1030	[thread overview]
Message-ID: <878vkegovg.fsf@rustcorp.com.au> (raw)

As featured on:
        https://bugs.launchpad.net/qemu-linaro/+bug/928432

Since we compile with -Werror, the presence of spice headers breaks
compile.  Yet except for x86-64, it doesn't compile, doesn't work, isn't
supported.  See: http://spice-space.org/faq.html

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
 configure |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index c9ff673..84118e4 100755
--- a/configure
+++ b/configure
@@ -2509,7 +2509,7 @@ if compile_prog "" "" ; then
     need_offsetof=no
 fi
 
-# spice probe
+# spice probe: x86-64 only (see http://spice-space.org/page/FAQ)
 if test "$spice" != "no" ; then
   cat > $TMPC << EOF
 #include <spice.h>
@@ -2517,7 +2517,8 @@ int main(void) { spice_server_new(); return 0; }
 EOF
   spice_cflags=$($pkg_config --cflags spice-protocol spice-server 2>/dev/null)
   spice_libs=$($pkg_config --libs spice-protocol spice-server 2>/dev/null)
-  if $pkg_config --atleast-version=0.6.0 spice-server >/dev/null 2>&1 && \
+  if [ "$ARCH" = x86_64 ] && \
+     $pkg_config --atleast-version=0.6.0 spice-server >/dev/null 2>&1 && \
      compile_prog "$spice_cflags" "$spice_libs" ; then
     spice="yes"
     libs_softmmu="$libs_softmmu $spice_libs"

             reply	other threads:[~2012-02-08  0:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-08  0:17 Rusty Russell [this message]
2012-02-08 15:22 ` [Qemu-devel] [PATCH] configure: ignore spice libraries on 32 bit Gerd Hoffmann
2012-03-07 10:30   ` Peter Maydell
2012-03-07 11:38     ` Gerd Hoffmann
2012-03-07 11:45       ` Peter Maydell
2012-03-07 12:33       ` Peter Maydell
2012-03-07 12:43         ` Gerd Hoffmann
2012-03-07 13:01           ` Alon Levy
2012-03-07 13:54             ` Peter Maydell
2012-03-07 14:19               ` [Qemu-devel] [PATCH] spice: require spice-protocol >= 0.8.1 Alon Levy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878vkegovg.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.