From: arnaud.patard@rtp-net.org (Arnaud Patard (Rtp))
To: linux-arm-kernel@lists.infradead.org
Subject: [patch 1/3] imx51: add pata device
Date: Fri, 22 Jul 2011 22:28:49 +0200 [thread overview]
Message-ID: <878vrqnjpa.fsf@lebrac.rtp-net.org> (raw)
In-Reply-To: <20110722190957.GF16561@pengutronix.de> ("Uwe Kleine-König"'s message of "Fri, 22 Jul 2011 21:09:57 +0200")
Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de> writes:
> On Fri, Jul 22, 2011 at 12:14:15PM -0300, Fabio Estevam wrote:
>> On Fri, Jul 22, 2011 at 7:37 AM, Arnaud Patard
>> <arnaud.patard@rtp-net.org> wrote:
>> ...
>> > +#define imx_mxc_pata_data_entry_single(soc) ? ? ? ? ? ? ? ? ? ? ? ? ? ?\
>> > + ? ? ? { ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? \
>> > + ? ? ? ? ? ? ? .iobase = soc ## _ATA_BASE_ADDR, ? ? ? ? ? ? ? ? ? ? ? ?\
>> > + ? ? ? ? ? ? ? .irq = soc ## _MXC_INT_ATA, ? ? ? ? ? ? ? ? ? ? ? ? ? ? \
>>
>> Why not imx_pata_data_entry_single instead?
>>
>> "imx_mxc" looks redundant.
> imx is the platform prefix, mxc_pata the device's name. So IMHO the name
> is right and consistent with the other device registration stuff.
next prev parent reply other threads:[~2011-07-22 20:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 10:37 [patch 0/3] imx: Efika: Add pata device Arnaud Patard (Rtp)
2011-07-22 10:37 ` [patch 1/3] imx51: add " Arnaud Patard (Rtp)
2011-07-22 15:14 ` Fabio Estevam
2011-07-22 19:09 ` Uwe Kleine-König
2011-07-22 20:28 ` Arnaud Patard (Rtp) [this message]
2011-07-22 21:10 ` Uwe Kleine-König
2011-07-22 19:10 ` Uwe Kleine-König
2011-07-22 10:37 ` [patch 2/3] imx51: add pata clock Arnaud Patard (Rtp)
2011-07-22 10:37 ` [patch 3/3] imx: efika: Enable pata Arnaud Patard (Rtp)
-- strict thread matches above, loose matches on Subject: below --
2011-07-26 14:54 [patch 0/3] imx: Efika: Add pata device Arnaud Patard (Rtp)
2011-07-26 14:54 ` [patch 1/3] imx51: add " Arnaud Patard (Rtp)
2011-07-28 14:42 ` Uwe Kleine-König
2011-07-24 18:39 [patch 0/3] imx: Efika: Add " Arnaud Patard (Rtp)
2011-07-24 18:39 ` [patch 1/3] imx51: add " Arnaud Patard (Rtp)
2011-07-16 20:44 [patch 0/3] imx: Efika: Add " Arnaud Patard (Rtp)
2011-07-16 20:44 ` [patch 1/3] imx51: add " Arnaud Patard (Rtp)
2011-07-16 21:22 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vrqnjpa.fsf@lebrac.rtp-net.org \
--to=arnaud.patard@rtp-net.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.