From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Subject: Re: [PATCH 1/3] [net/9p] Fix the size of receive buffer packing onto VirtIO ring. Date: Fri, 01 Jul 2011 16:51:32 +0530 Message-ID: <878vsint4z.fsf@linux.vnet.ibm.com> References: <1309475921-12171-1-git-send-email-jvrao@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, ericvh@gmail.com, "Venkateswararao Jujjuri \(JV\)" To: "Venkateswararao Jujjuri \(JV\)" , v9fs-developer@lists.sourceforge.net Return-path: Received: from e33.co.us.ibm.com ([32.97.110.151]:36223 "EHLO e33.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754854Ab1GALVr (ORCPT ); Fri, 1 Jul 2011 07:21:47 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e33.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p61BECIQ002038 for ; Fri, 1 Jul 2011 05:14:12 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p61BLgJd087804 for ; Fri, 1 Jul 2011 05:21:42 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p615Lee9009636 for ; Thu, 30 Jun 2011 23:21:41 -0600 In-Reply-To: <1309475921-12171-1-git-send-email-jvrao@linux.vnet.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, 30 Jun 2011 16:18:39 -0700, "Venkateswararao Jujjuri (JV)" wrote: > Signed-off-by: Venkateswararao Jujjuri " > --- > net/9p/trans_virtio.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c > index 244e707..0ec5423 100644 > --- a/net/9p/trans_virtio.c > +++ b/net/9p/trans_virtio.c > @@ -367,7 +367,7 @@ req_retry_pinned: > in += inp; > } else { > in = pack_sg_list(chan->sg, out, VIRTQUEUE_NUM, rdata, > - client->msize); > + req->rc->capacity); > } > > err = virtqueue_add_buf(chan->vq, chan->sg, out, in, req->tc); So when will req->rc->capacity be different from client->msize ? Can we get details for that documented in p9_tag_alloc ? The above pack_sg_list will only be called for non-zero copy case ? In that case won't client->size be same as rc->capacity ? -aneesh