From: Kalle Valo <kvalo@adurom.com>
To: David Gnedt <david.gnedt@davizone.at>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org,
Grazvydas Ignotas <notasas@gmail.com>,
Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
Subject: Re: [PATCH 05/18] wl1251: retry power save entry
Date: Wed, 02 Feb 2011 00:18:10 +0200 [thread overview]
Message-ID: <878vxzcsbh.fsf@purkki.adurom.net> (raw)
In-Reply-To: <4D45A5AD.4010402@davizone.at> (David Gnedt's message of "Sun\, 30 Jan 2011 18\:53\:49 +0100")
David Gnedt <david.gnedt@davizone.at> writes:
> Port of the power save entry retry code from wl1251 driver version included
> in the Maemo Fremantle kernel.
> This tries to enable power save mode up to 3 times before failing.
[...]
> + if (wl->psm_entry_retry < WL1251_PSM_ENTRY_RETRIES) {
> + wl->psm_entry_retry++;
> + ret = wl1251_ps_set_mode(wl, STATION_POWER_SAVE_MODE);
> + } else {
> + wl1251_error("Power save entry failed, giving up");
> + wl->psm_entry_retry = 0;
> + }
If firmware fails to send the nullfunc frame, something is wrong with
the connection and we should notify about this to mac80211. At least
wl12xx uses ieee80211_connection_loss(), maybe that's the best option
here?
--
Kalle Valo
next prev parent reply other threads:[~2011-02-01 22:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-30 17:53 [PATCH 05/18] wl1251: retry power save entry David Gnedt
2011-01-30 19:10 ` David Gnedt
2011-02-01 22:18 ` Kalle Valo [this message]
2011-02-06 14:04 ` David Gnedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vxzcsbh.fsf@purkki.adurom.net \
--to=kvalo@adurom.com \
--cc=GNUtoo@no-log.org \
--cc=david.gnedt@davizone.at \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.