All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Sanjeev Premi <premi@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCHv4] omap3: Add basic support for 720MHz part
Date: Fri, 21 Jan 2011 13:54:49 -0800	[thread overview]
Message-ID: <878vydgbx2.fsf@ti.com> (raw)
In-Reply-To: <1295522814-30351-1-git-send-email-premi@ti.com> (Sanjeev Premi's message of "Thu, 20 Jan 2011 16:56:54 +0530")

Sanjeev Premi <premi@ti.com> writes:

> This patch adds support for new speed enhanced parts with ARM
> and IVA running at 720MHz and 520MHz respectively. These parts
> can be probed at run-time by reading PRODID.SKUID[3:0] at
> 0x4830A20C [1].

>From my earlier review[1] of this patch:

Please expand this a little to describe exactly which parts have this
feature.  All OMAP3?  34xx? 35xx? what about 36xx/37xx?  ISTR the
runtime probing for this feature is available on 35xx but not on 34xx,
but a summary of this should be here.

In addition, if I'm recalling correctly about the inability to do
runtime detection on non-35xx parts, maybe documenting how board code
would enable this OPP would be helpful too.

Thanks,

Kevin

[1] http://marc.info/?l=linux-omap&m=129441890030307&w=2


      reply	other threads:[~2011-01-21 21:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-20 11:26 [PATCHv4] omap3: Add basic support for 720MHz part Sanjeev Premi
2011-01-21 21:54 ` Kevin Hilman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878vydgbx2.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=premi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.