All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Joachim <svenjoac@gmx.de>
To: Roland Dreier <rdreier@cisco.com>
Cc: Miles Lane <miles.lane@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Ben Skeggs <bskeggs@redhat.com>,
	Maarten Maathuis <madman2003@gmail.com>
Subject: Re: 2.6.36-rc8 -- drivers/built-in.o: In function `nouveau_acpi_edid': (.text+0xf7c04): undefined reference to `acpi_video_get_edid'
Date: Sun, 17 Oct 2010 09:18:09 +0200	[thread overview]
Message-ID: <878w1xp9se.fsf@turtle.gmx.de> (raw)
In-Reply-To: <adad3r9hn1x.fsf@cisco.com> (Roland Dreier's message of "Sat, 16 Oct 2010 13:58:50 -0700")

On 2010-10-16 22:58 +0200, Roland Dreier wrote:

>  > drivers/built-in.o: In function `nouveau_acpi_edid':
>  > (.text+0xf7c04): undefined reference to `acpi_video_get_edid'
>  > make: *** [.tmp_vmlinux1] Error 1
>
> The problem is:
>
>  > CONFIG_ACPI=y
>  > CONFIG_ACPI_VIDEO=m
>
> but
>
>  > CONFIG_DRM_NOUVEAU=y
>
> So the built-in nouveau code tries to reference the modular acpi video
> code.

The nouveau tree has a fix for this already, in commit
4587d1cfa8b54ba3dd3095c3e6f12d02390494c6:

--8<---------------cut here---------------start------------->8---
diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig
index d2d2804..72730e9 100644
--- a/drivers/gpu/drm/nouveau/Kconfig
+++ b/drivers/gpu/drm/nouveau/Kconfig
@@ -10,6 +10,7 @@ config DRM_NOUVEAU
 	select FB
 	select FRAMEBUFFER_CONSOLE if !EMBEDDED
 	select FB_BACKLIGHT if DRM_NOUVEAU_BACKLIGHT
+	select ACPI_VIDEO if ACPI
 	help
 	  Choose this option for open-source nVidia support.
 
--8<---------------cut here---------------end--------------->8---

Maybe this should be cherry-picked for 2.6.36.

Sven

      parent reply	other threads:[~2010-10-17  7:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-15  2:46 2.6.36-rc8 -- drivers/built-in.o: In function `nouveau_acpi_edid': (.text+0xf7c04): undefined reference to `acpi_video_get_edid' Miles Lane
2010-10-16 20:58 ` Roland Dreier
2010-10-17  1:00   ` Miles Lane
2010-10-17  1:33     ` Roland Dreier
2010-10-17  3:50       ` Miles Lane
2010-10-17  7:18   ` Sven Joachim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878w1xp9se.fsf@turtle.gmx.de \
    --to=svenjoac@gmx.de \
    --cc=bskeggs@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=madman2003@gmail.com \
    --cc=miles.lane@gmail.com \
    --cc=rdreier@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.