From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Hiremath, Vaibhav" <hvaibhav@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"tony@atomide.com" <tony@atomide.com>,
"Govindarajan, Sriramakrishnan" <srk@ti.com>
Subject: Re: [PATCH 2/3] AM35xx: Introduce am35xx.h file
Date: Thu, 07 Jan 2010 11:14:16 -0800 [thread overview]
Message-ID: <878wc920dz.fsf@deeprootsystems.com> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E7394044A397EDB@dbde02.ent.ti.com> (Vaibhav Hiremath's message of "Thu\, 7 Jan 2010 23\:08\:54 +0530")
"Hiremath, Vaibhav" <hvaibhav@ti.com> writes:
>> -----Original Message-----
>> From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
>> Sent: Thursday, January 07, 2010 5:20 AM
>> To: Hiremath, Vaibhav
>> Cc: linux-omap@vger.kernel.org; tony@atomide.com; Govindarajan,
>> Sriramakrishnan
>> Subject: Re: [PATCH 2/3] AM35xx: Introduce am35xx.h file
>>
>> hvaibhav@ti.com writes:
>>
>> > From: Vaibhav Hiremath <hvaibhav@ti.com>
>> >
>> > Add base address definations for new AM35xx IPSS modules, like
>> > VPFE, USBOTG, CPGMAC.
>> >
>> > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
>> > Signed-off-by: Sriramakrishnan <srk@ti.com>
>> > ---
>> > arch/arm/plat-omap/include/plat/am35xx.h | 25
>> +++++++++++++++++++++++++
>> > arch/arm/plat-omap/include/plat/hardware.h | 1 +
>> > 2 files changed, 26 insertions(+), 0 deletions(-)
>> > create mode 100644 arch/arm/plat-omap/include/plat/am35xx.h
>> >
>> > diff --git a/arch/arm/plat-omap/include/plat/am35xx.h
>> b/arch/arm/plat-omap/include/plat/am35xx.h
>> > new file mode 100644
>> > index 0000000..d41bd61
>> > --- /dev/null
>> > +++ b/arch/arm/plat-omap/include/plat/am35xx.h
>> > @@ -0,0 +1,25 @@
>> > +/*:
>> > + * Address mappings and base address for AM35XX specific
>> interconnects
>> > + * and peripherals.
>> > + *
>> > + * Copyright (C) 2009 Texas Instruments
>> > + *
>> > + * Author: Sriramakrishnan <srk@ti.com>
>> > + * Vaibhav Hiremath <hvaibhav@ti.com>
>> > + *
>> > + * This program is free software; you can redistribute it and/or
>> modify
>> > + * it under the terms of the GNU General Public License version 2
>> as
>> > + * published by the Free Software Foundation.
>> > + */
>> > +#ifndef __ASM_ARCH_AM35XX_H
>> > +#define __ASM_ARCH_AM35XX_H
>> > +
>> > +/*
>> > + * Base addresses
>> > + */
>> > +#define AM35XX_IPSS_EMAC_BASE 0x5C000000
>> > +#define AM35XX_IPSS_USBOTGSS_BASE 0x5C040000
>> > +#define AM35XX_IPSS_HECC_BASE 0x5C050000
>> > +#define AM35XX_IPSS_VPFE_BASE 0x5C060000
>>
>> I think this secont needs ome more comments. In the 34xx TRM memory
>> map, this region is shown as IVA2, so folks familiar with 34xx might
>> be confused.
>>
> [Hiremath, Vaibhav] I will update the comment with sufficient info.
>
>> That being said, is there any reason to have these in a global
>> header
>> file? Nobody should use these except SoC/board init code, so these
>> should probably stay in arch/arm/mach-omap2 in AM35x specific code.
>>
> [Hiremath, Vaibhav] Agreed, but there are some occurrences where these macros may required to use in plat-omap/ directory. Just for an example -
>
> Macro OMAP443X_SCM_BASE, defined in
> arch/arm/plat-omap/include/plat/omap44xx.h file is getting used in
> arch/arm/plat-omap/common.c file.
OK, but SCM_BASE has nothing to do with the base addresses you're
adding in this patch.
My point is that I don't see a need for the values in this patch to be
defined in a global header.
Kevin
next prev parent reply other threads:[~2010-01-07 19:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-04 13:51 [PATCH 2/3] AM35xx: Introduce am35xx.h file hvaibhav
2010-01-06 23:50 ` Kevin Hilman
2010-01-07 17:38 ` Hiremath, Vaibhav
2010-01-07 19:14 ` Kevin Hilman [this message]
2010-01-07 19:18 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878wc920dz.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=hvaibhav@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=srk@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.