All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@sunsite.dk>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] gcc: Add option to build final-gcc with sysroot option
Date: Sat, 28 Nov 2009 21:41:33 +0100	[thread overview]
Message-ID: <878wdq4c1u.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <4B0FEA2F.9080508@st.com> (Carmelo AMOROSO's message of "Fri\, 27 Nov 2009 16\:03\:11 +0100")

>>>>> "Carmelo" == Carmelo AMOROSO <carmelo.amoroso@st.com> writes:

Hi,

 >> I'm not convinced we need a user visible option for this - It's a very
 >> lowlevel detail that I don't think most users will know what to answer
 >> to - Any reason we cannot just automatically enable this if
 >> BR2_PTHREADS_NATIVE is enabled?
 >> 
 Carmelo> No at all, indeed it is the better choice. Feel free to
 Carmelo> rework/adapt it.

Hmm, looking closer at it you're having me confused. You changed
gcc-uclibc-3.x.mk (E.G. the build rules used when NOT using sysroot) to
add a --with-sysroot configure argument. I would imagine this belongs in
gcc-uclibc-4.x.mk (E.G. the build rules used when using sysroot), but
there we already pass --with-sysroot=$(STAGING_DIR) to the final gcc
build (the BR2_CONFIGURE_STAGING_SYSROOT variable).

So is this change really needed?

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2009-11-28 20:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1258969104-4217-1-git-send-email-carmelo.amoroso@st.com>
2009-11-27 14:51 ` [Buildroot] [PATCH] gcc: Add option to build final-gcc with sysroot option Peter Korsgaard
     [not found]   ` <4B0FEA2F.9080508@st.com>
2009-11-27 15:07     ` Peter Korsgaard
2009-11-28 20:41     ` Peter Korsgaard [this message]
     [not found]       ` <4B1374D2.9090701@st.com>
2009-11-30  8:08         ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878wdq4c1u.fsf@macbook.be.48ers.dk \
    --to=jacmet@sunsite.dk \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.