From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Korsgaard Subject: Re: About a suspicious msleep during doxfer in s3c2410 i2c bus driver Date: Fri, 31 Jul 2009 10:05:00 +0200 Message-ID: <878wi5wa4z.fsf@macbook.be.48ers.dk> References: <5e9665e10907220112m1dbf4975icf1511bc4ac3a1bf@mail.gmail.com> <20090722124333.GC7622@sirena.org.uk> <20090722160639.GB14026@rakim.wolfsonmicro.main> <20090730221841.GG8850@fluff.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <20090730221841.GG8850-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org> (Ben Dooks's message of "Thu\, 30 Jul 2009 23\:18\:41 +0100") Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ben Dooks Cc: Mark Brown , Dongsoo Kim , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ben-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org, ????????? , ????????? , Dongsoo Kim , ?????? ??? List-Id: linux-i2c@vger.kernel.org >>>>> "Ben" == Ben Dooks writes: Hi, >> It wasn't for the client devices, it was for issues with >> synchronisation with the controller hardware. I'm just going on >> the basis of recollections of previous conversations with Ben >> here; I'm not sure to what extent this might be an issue with the >> way the hardware works requiring the driver to jump through hoops. Ben> I think this has been in here for a while, and may well not be Ben> necessary any more. If anyone else has tested this without the Ben> msleep() here, then I'd be interested to know. I'll test on my 6410 board over the weekend. Notice that I've been hacking on the uboot drivers/i2c/s3c24x0_i2c.c file to add s3c64xx support, and I there had to add a udelay before setting the start condition to get it to work stable. -- Bye, Peter Korsgaard