From: Kevin Hilman <khilman@deeprootsystems.com>
To: linux-omap@vger.kernel.org
Subject: Re: [PATCH v4] OMAP2/3/4: PM: reset USB OTG module on boot
Date: Wed, 24 Jun 2009 15:27:32 -0700 [thread overview]
Message-ID: <878wjh1d4b.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1245877725-28896-1-git-send-email-khilman@deeprootsystems.com> (Kevin Hilman's message of "Wed\, 24 Jun 2009 14\:08\:45 -0700")
Kevin Hilman <khilman@deeprootsystems.com> writes:
[...]
> + iclk = clk_get(NULL, "hsotgusb_ick");
> + if (WARN_ON(!iclk))
> + goto out;
doh, this error check is wrong and will never fail.
Need to use IS_ERR(). v5 spinning up...
Kevin
prev parent reply other threads:[~2009-06-24 22:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 21:08 [PATCH v4] OMAP2/3/4: PM: reset USB OTG module on boot Kevin Hilman
2009-06-24 22:27 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878wjh1d4b.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.