From: Andi Kleen <andi@firstfloor.org>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] x86: ia32_signal: remove unnecessary padding
Date: Wed, 12 Nov 2008 13:56:21 +0100 [thread overview]
Message-ID: <878wrpdrwq.fsf@basil.nowhere.org> (raw)
In-Reply-To: <491A496B.5010505@ct.jp.nec.com> (Hiroshi Shimamoto's message of "Tue, 11 Nov 2008 19:11:39 -0800")
Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> writes:
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>
> Impact: cleanup
Actually it's not a cleanup.
> Remove unnecessary paddings, this saves 4 bytes.
This might actually break code. The code is not actually used,
but only kept around because some old gdb versions used this
code as a marker for detecting signals.
I don't know if they require the padding or not, but it seems
somewhat risky to change a legacy marker like this.
-Andi
--
ak@linux.intel.com
next prev parent reply other threads:[~2008-11-12 12:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 3:09 [PATCH 1/2] x86: signal_32: introduce retcode and rt_retcode Hiroshi Shimamoto
2008-11-12 3:11 ` [PATCH 2/2] x86: ia32_signal: remove unnecessary padding Hiroshi Shimamoto
2008-11-12 11:29 ` Ingo Molnar
2008-11-12 12:33 ` Mikael Pettersson
2008-11-12 17:12 ` H. Peter Anvin
2008-11-12 18:02 ` Hiroshi Shimamoto
2008-11-12 18:12 ` H. Peter Anvin
2008-11-13 8:45 ` Mikael Pettersson
2008-11-13 17:38 ` H. Peter Anvin
2008-11-12 12:56 ` Andi Kleen [this message]
2008-11-12 18:34 ` Hiroshi Shimamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878wrpdrwq.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=h-shimamoto@ct.jp.nec.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.