From: Elias Oltmanns <eo@nebensachen.de>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ide: Build fix for CONFIG_IDE_PROC_FS=n
Date: Tue, 02 Sep 2008 00:52:55 +0200 [thread overview]
Message-ID: <878wub1nso.fsf@denkblock.local> (raw)
In-Reply-To: <200808311752.06818.bzolnier@gmail.com> (Bartlomiej Zolnierkiewicz's message of "Sun, 31 Aug 2008 17:52:05 +0200")
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
> On Friday 29 August 2008, Elias Oltmanns wrote:
>> Recent changes have broken compilation when CONFIG_IDE_PROC_FS is not set.
>>
>> Signed-off-by: Elias Oltmanns <eo@nebensachen.de>
>
> Thanks!
>
> I integrated your fixes into guilty patches ("ide-floppy: move /proc handling
> to ide-floppy_proc.c" and "ide-disk: move /proc handling to ide-disk_proc.c")
> to preserve bisection.
Yes, that's fine with me, but in the case of ide-disk_proc.h things
apparently went wrong. As of next-20080901, I still have the line
ide-disk_mod-y += ide-disk.o ide-disk_ioctl.o ide-disk_proc.o
in the Makefile. Could you please truncate that line appropriately?
Regards,
Elias
next prev parent reply other threads:[~2008-09-01 22:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-29 21:37 [PATCH] ide: Build fix for CONFIG_IDE_PROC_FS=n Elias Oltmanns
2008-08-30 11:19 ` Sergei Shtylyov
2008-08-30 11:22 ` Sergei Shtylyov
2008-08-30 16:23 ` Elias Oltmanns
2008-08-30 16:29 ` Sergei Shtylyov
2008-08-31 15:52 ` Bartlomiej Zolnierkiewicz
2008-09-01 22:52 ` Elias Oltmanns [this message]
2008-09-02 10:35 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878wub1nso.fsf@denkblock.local \
--to=eo@nebensachen.de \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.