From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KQKDZ-0005T6-Nl for mharc-grub-devel@gnu.org; Tue, 05 Aug 2008 06:56:41 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQKDW-0005Qm-Ix for grub-devel@gnu.org; Tue, 05 Aug 2008 06:56:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQKDU-0005Ob-Mr for grub-devel@gnu.org; Tue, 05 Aug 2008 06:56:38 -0400 Received: from [199.232.76.173] (port=59794 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQKDU-0005OB-Bm for grub-devel@gnu.org; Tue, 05 Aug 2008 06:56:36 -0400 Received: from smtp-vbr7.xs4all.nl ([194.109.24.27]:1464) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KQKDT-0003tt-Ue for grub-devel@gnu.org; Tue, 05 Aug 2008 06:56:36 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr7.xs4all.nl (8.13.8/8.13.8) with ESMTP id m75AuYvk056180 for ; Tue, 5 Aug 2008 12:56:35 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <87od47hior.fsf@xs4all.nl> Mail-Copies-To: mgerards@xs4all.nl Date: Tue, 05 Aug 2008 12:59:13 +0200 In-Reply-To: (bean123ch@gmail.com's message of "Tue, 5 Aug 2008 18:32:45 +0800") Message-ID: <878wvbg22m.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] Fix color problem the grub-emu X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Aug 2008 10:56:39 -0000 Bean writes: > On Tue, Aug 5, 2008 at 6:15 PM, Marco Gerards wrote: >> Hi, >> >> Bean writes: >> >>> Currently, the color handling in grub-emu is broken, sometimes you see >>> nothing on screen. This patch fix it, now variable menu_color_normal >>> and menu_color_highlight works properly in grub-emu. >>> >>> 2008-08-02 Bean >>> >>> * util/console.c (grub_console_cur_color): New variable. >>> (grub_console_standard_color): Likewise. >>> (grub_console_normal_color): Likewise. >>> (grub_console_highlight_color): Likewise. >>> (color_map): Likewise. >>> (use_color): Likewise. >>> (NUM_COLORS): New macro. >>> (grub_ncurses_setcolorstate): Handle color properly. >>> (grub_ncurses_setcolor): Don't change color here, just remember the >>> settings, color will be set in grub_ncurses_setcolorstate. >>> (grub_ncurses_getcolor): New function. >>> (grub_ncurses_init): Initialize color pairs. >>> (grub_term grub_ncurses_term): New member grub_ncurses_getcolor. >> >> This should be: >> >> (grub_ncurses_term): New member grub_ncurses_getcolor. >> >>> -- >>> Bean >>> >>> diff --git a/util/console.c b/util/console.c >>> index 8c9401c..53fc5d0 100644 >>> --- a/util/console.c >>> +++ b/util/console.c >>> @@ -41,6 +41,28 @@ >>> >>> static int grub_console_attr = A_NORMAL; >>> >>> +grub_uint8_t grub_console_cur_color = 7; >> >> Any reason why this is not static? > > Hi, > > This files include , which define > grub_console_cur_color as global variable. Although grub-emu doesn't > use this variable itself, but if I define it as static, it will > generate a warning message. Ah, ok :-) -- Marco