From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1GNw1t-0002YM-Gu
	for mharc-grub-devel@gnu.org; Thu, 14 Sep 2006 14:33:41 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1GNw1r-0002UG-8f
	for grub-devel@gnu.org; Thu, 14 Sep 2006 14:33:39 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1GNw1p-0002SL-P7
	for grub-devel@gnu.org; Thu, 14 Sep 2006 14:33:38 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1GNw1p-0002SC-Le
	for grub-devel@gnu.org; Thu, 14 Sep 2006 14:33:37 -0400
Received: from [194.109.24.21] (helo=smtp-vbr1.xs4all.nl)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1GNw3p-0003dd-DX
	for grub-devel@gnu.org; Thu, 14 Sep 2006 14:35:41 -0400
Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net
	[145.99.174.249])
	by smtp-vbr1.xs4all.nl (8.13.6/8.13.6) with ESMTP id k8EIXZ3Z089532
	for <grub-devel@gnu.org>; Thu, 14 Sep 2006 20:33:36 +0200 (CEST)
	(envelope-from mgerards@xs4all.nl)
From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <20060914182803.GA20575@khazad.dyndns.org>
Mail-Copies-To: mgerards@xs4all.nl
Date: Thu, 14 Sep 2006 20:40:53 +0200
In-Reply-To: <20060914182803.GA20575@khazad.dyndns.org> (Robert Millan's
	message of "Thu, 14 Sep 2006 20:28:03 +0200")
Message-ID: <878xkmthoq.fsf@xs4all.nl>
User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Virus-Scanned: by XS4ALL Virus Scanner
Subject: Re: [PATCH] don't assume floppy device exists
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Sep 2006 18:33:40 -0000

Robert Millan <rmh@aybabtu.com> writes:

> grub-install used to fail with "/dev/fd0 not found" errors.  See attached patch.

Thanks for the patch.  Just keep sending them. ;-)

> 2006-09-14  Robert Millan  <rmh@aybabtu.com>
>
> 	* util/i386/pc/grub-mkdevicemap.c:  Make sure floppy device exists
> 	before adding it to device.map.

I think it would be better to say "the floppy drive", no?

> +      if (stat (name, &st) < 0)
> +	break;

The indentation looks a bit weird in my mailclient.  Please make sure
the b of break is below the space after if.

After that, feel free to commit it.

--
Marco