From: Momchil Velikov <velco@fadata.bg>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: mumismo@wanadoo.es (Jordi),
torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: 2.5.1pre9 change several if (x) BUG to BUG_ON(x)
Date: 06 Jan 2002 16:48:46 +0200 [thread overview]
Message-ID: <878zbba629.fsf@fadata.bg> (raw)
In-Reply-To: <E16NEar-0005Ln-00@the-village.bc.nu>
In-Reply-To: <E16NEar-0005Ln-00@the-village.bc.nu>
>>>>> "Alan" == Alan Cox <alan@lxorguk.ukuu.org.uk> writes:
>> Yes, only that, even a trained monkey is able to make this patch, but i think
>> is a good way to make people confortable with BUG_ON
Alan> Your patch looks wrong (ook ook! 8)) - if you build without BUG enabled you
Alan> don't make various function calls with your change. BUG_ON has the C nasty
Alan> assert() does that makes it a horrible horrible idea and its unfortunate
Alan> it got put in.
Alan> BUG_ON(function(x,y))
#ifdef DEBUG
#define BUG_ON(x) if (x) BUG()
#else
#define BUG_ON(x) (void)(x)
#endif
next prev parent reply other threads:[~2002-01-06 14:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-06 12:34 [PATCH]: 2.5.1pre9 change several if (x) BUG to BUG_ON(x) Jordi
2002-01-06 14:48 ` Alan Cox
2002-01-06 14:48 ` Momchil Velikov [this message]
2002-01-06 16:10 ` Jordi
2002-01-06 16:26 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878zbba629.fsf@fadata.bg \
--to=velco@fadata.bg \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mumismo@wanadoo.es \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.