From: David Howells <dhowells@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: akpm@osdl.org, linux-fsdevel@vger.kernel.org
Subject: Re: fscache review comments, part 3
Date: Fri, 06 Oct 2006 14:25:54 +0100 [thread overview]
Message-ID: <8798.1160141154@redhat.com> (raw)
In-Reply-To: <20060928164547.GC3497@infradead.org>
Christoph Hellwig <hch@infradead.org> wrote:
> - generic_file_buffered_write_one_kernel_page seems generally fine, but
> you must not call this directly from cachefiles but rather go through
> a file operation for it.
I can't do that for one very good reason: you insisted that I take out[*] all
the provision of a struct file * for doing I/O to the cache, and without that
I can't call file ops. You can't have it both ways. Sorry.
David
[*] You may remember the ENFILE avoidance patch that you objected strenuously
to.
next prev parent reply other threads:[~2006-10-06 13:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 16:45 fscache review comments, part 3 Christoph Hellwig
2006-09-29 9:23 ` David Howells
2006-09-29 16:43 ` Christoph Hellwig
2006-10-06 13:25 ` David Howells [this message]
2006-10-07 21:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8798.1160141154@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.