Re: [PATCH] ALSA: hda/tegra: Re-enable SDO workaround for Tegra194

[Takashi Iwai <tiwai@suse.de>]

On Tue, 29 Sep 2026 19:22:25 +0200,
Aaron Kling wrote:
> 
> On Tue, Sep 29, 2026 at 6:12 AM Thierry Reding
> <thierry.reding@kernel.org> wrote:
> >
> > On Sat, Sep 26, 2026 at 02:24:19AM -0500, Aaron Kling via B4 Relay wrote:
> > > From: Aaron Kling <webgeek1234@gmail.com>
> > >
> > > This workaround was originally added for Tegra194, but no longer gets
> > > applied for it. Commit 615d43540043 ("ALSA: hda/tegra: fix tegra-hda on
> > > tegra30 soc") changed the guard to tegra30-hda, which worked because all
> > > affected archs had the fallback compatible. However, commit 7f0ea5acfc19
> > > ("arm64: tegra: Use correct compatible string for Tegra194 HDA") removed
> > > the fallback compatible for Tegra194, causing this to break.
> > >
> > > Fixes: 7f0ea5acfc19 ("arm64: tegra: Use correct compatible string for Tegra194 HDA")
> > > Cc: stable@vger.kernel.org
> > > Assisted-by: LLM
> > > Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> > > ---
> > > ALSA: hda/tegra: Re-enable SDO workaround for Tegra194
> > > ---
> > >  sound/hda/controllers/tegra.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > Maybe we should move this out of of_device_is_compatible() conditionals
> > and into hda_tegra_soc instead. That would make the checks for this a
> > lot more consistent and robust.
> 
> I received a notification from Takashi Iwai that this has already been
> picked up, but it was only sent to me and not the list. Not sure why.
> But looking at -next, it's already there. Not sure if you would want
> to have that pulled back for updates or do followups later.

Ah, I overlooked that your mail had 'Reply-To', and my mailer followed
it as default.

And yes, the patch was already queued for 7.4.  But if anyone has a
better alternative, feel free to submit as an incremental fix.


thanks,

Takashi