Re: [PATCH] net/vmnet: Add host address options for vmnet-host

[Markus Armbruster <armbru@redhat.com>]

Tim Pambor <timpambor@gmail.com> writes:

> When a vmnet-host interface is added to an isolated network via
> 'net-uuid', vmnet does not provide DHCP and the host side of the

Comma after DHCP?

> bridge gets no address, so the host cannot talk to guests on that
> network without manually assigning an IP address to the bridge
> interface after QEMU has started.
>
> vmnet provides the vmnet_host_ip_address_key,
> vmnet_host_subnet_mask_key and vmnet_host_ipv6_address_key
> properties to assign addresses to the host interface in this case.
> Expose them as the 'host-ip-address', 'host-subnet-mask' and
> 'host-ipv6-address' options of the vmnet-host backend.
>
> Signed-off-by: Tim Pambor <timpambor@gmail.com>

[...]

> diff --git a/qapi/net.json b/qapi/net.json
> index b46af1fdc9..38b43d20ed 100644
> --- a/qapi/net.json
> +++ b/qapi/net.json
> @@ -795,6 +795,16 @@
>  #     is allowed only with other interfaces added to this network
>  #     identified by the UUID.  Requires at least macOS Big Sur 11.0.
>  #
> +# @host-ip-address: The IPv4 address to set on the host side of the
> +#     interface.  Only applicable when @net-uuid is also specified.
> +#     Must be specified along with @host-subnet-mask.
> +#
> +# @host-subnet-mask: The IPv4 subnet mask to set on the host side of
> +#     the interface.  Must be specified along with @host-ip-address.
> +#
> +# @host-ipv6-address: The IPv6 address to set on the host side of the
> +#     interface.  Only applicable when @net-uuid is also specified.
> +#
>  # Since: 7.1
>  ##
>  { 'struct': 'NetdevVmnetHostOptions',
> @@ -803,7 +813,10 @@
>      '*end-address':   'str',
>      '*subnet-mask':   'str',
>      '*isolated':      'bool',
> -    '*net-uuid':      'str' },
> +    '*net-uuid':      'str',
> +    '*host-ip-address': 'str',
> +    '*host-subnet-mask': 'str',
> +    '*host-ipv6-address': 'str' },
>    'if': 'CONFIG_VMNET' }
>  
>  ##

QAPI schema
Acked-by: Markus Armbruster <armbru@redhat.com>

[...]