Re: [PATCH v2 2/4] optee_ta_avb.h: add TA_AVB_CMD_READ_PERSIST_VALUE2 define

[Mattijs Korpershoek <mkorpershoek@kernel.org>]

Hi Rasmus,

Thank you for the patch.

On Thu, Sep 03, 2026 at 23:22, Rasmus Villemoes <ravi@prevas.dk> wrote:

> Add the new TA_AVB_CMD_READ_PERSIST_VALUE2 definition, and synchronize
> the comment for the existing TA_AVB_CMD_READ_PERSIST_VALUE with
> optee-os' ta/avb/include/ta_avb.h.
>
> Signed-off-by: Rasmus Villemoes <ravi@prevas.dk>

I see that this is not yet merged here:
https://github.com/OP-TEE/optee_os/pull/7959

I hope there won't be any other changes in optee_os, otherwise we will
have to re-update here again.

In any case, looks good:

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

> ---
>  include/tee/optee_ta_avb.h | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/include/tee/optee_ta_avb.h b/include/tee/optee_ta_avb.h
> index 949875a64cb..d8db6d257bc 100644
> --- a/include/tee/optee_ta_avb.h
> +++ b/include/tee/optee_ta_avb.h
> @@ -47,6 +47,7 @@
>  
>  /*
>   * Reads a persistent value corresponding to the given name.
> + * Only reads as much of the value as will fit in the provided buffer.
>   *
>   * in	params[0].u.memref:	persistent value name
>   * out	params[1].u.memref:	read persistent value buffer
> @@ -61,4 +62,15 @@
>   */
>  #define TA_AVB_CMD_WRITE_PERSIST_VALUE	5
>  
> +/*
> + * Reads a persistent value corresponding to the given name.
> + * If the provided buffer is smaller than the value, returns
> + * TEE_ERROR_SHORT_BUFFER and sets the output buffer size to the true
> + * size of the value.
> + *
> + * in	params[0].memref:	persistent value name
> + * out	params[1].memref:	read persistent value buffer
> + */
> +#define TA_AVB_CMD_READ_PERSIST_VALUE2	6
> +
>  #endif /* __TA_AVB_H */
> -- 
> 2.55.0