Re: [PATCH] board: ti: am62x: Fix build without TI_I2C_BOARD_DETECT

[Mattijs Korpershoek via U-Boot <u-boot@lists.u-boot-project.org>]

On Thu, Jul 16, 2026 at 13:08, Anshul Dalal <anshuld@ti.com> wrote:

> On Wed, 15 Jul 2026 11:32:26 +0800, Guo Hao <guohaoprc@163.com> wrote:
>> setup_board_eeprom_env() and setup_serial_am6() are only available when
>> TI_I2C_BOARD_DETECT is enabled.
>> 
>> IS_ENABLED() does not remove the guarded statements during preprocessing,
>> so disabling TI_I2C_BOARD_DETECT results in an implicit function
>> declaration error. Use a preprocessor condition to match the condition
>> used for the function definition.
>> 
>> Fixes: ff1b83c095c2 ("board: am62x: Add support for reading eeprom data")
>> Signed-off-by: Guo Hao <guohaoprc@163.com>
>
> This is a valid fix however I wonder if there's an actual use-case where someone
> might want to disable TI_I2C_BOARD_DETECT on an EVM board.

I agree with Anshul here. What's the use use-case for disabling i2c
board detection?

Also, if we really want it disabled, we could also create stub functions
instead of replacing this.

>
> Also, it looks like the same issue exists for other platforms too (AM64x, AM65x,
> J721s2 ...).
>
> -- 
> Anshul Dalal <anshuld@ti.com>