Re: [PATCH V8 07/15] monitor: Update tracking iothread users with holder

[Markus Armbruster <armbru@redhat.com>]

Zhang Chen <zhangckid@gmail.com> writes:

> On Wed, Jun 3, 2026 at 1:20 AM Markus Armbruster <armbru@redhat.com> wrote:
>>
>> Zhang Chen <zhangckid@gmail.com> writes:
>>
>> > Based on monitor ID tracking iothread users with holder.
>> > Introduce the AioContext in the Monitor struct to avoid repeated calls to
>> > iothread_get_aio_context()
>>
>> iothread_get_aio_context(iothread) returns iothread->ctx.  I doubt
>> avoiding the call is worth the complexity yet another variable adds.
>>
>> >                            and ensure symmetrical ref/unref during
>> > monitor lifecycle.
>>
>> What do you mean by that?
>
> As we discussed with Stefan before, the iothread_ref/unref need to
> call in pairs, for example the virtio-blk. But the monitor implementation
> is special, it have the monitor_suspend/resume with iothread.
> So I try to introduce the mon->ctx to simplify it.

I appreciate your attempt to simplify things.  I'm having difficulties
seeing what exactly becomes simpler.  This is likely me being dense.
Can you explain it to me real slow, perhaps with examples?

[...]