From: Gabriel Krisman Bertazi <krisman@suse.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Caleb Sander Mateos <csander@purestorage.com>,
Yi Xie <xieyi@kylinos.cn>,
io-uring@vger.kernel.org
Subject: Re: [PATCH] io_uring: parenthesize io_ring_head_to_buf() expansion
Date: Thu, 14 May 2026 10:58:28 -0400 [thread overview]
Message-ID: <87a4u2597v.fsf@mailhost.krisman.be> (raw)
In-Reply-To: <49a10373-f2d8-4813-b9d6-25cd2a0f2fe6@kernel.dk> (Jens Axboe's message of "Thu, 14 May 2026 08:25:21 -0600")
Jens Axboe <axboe@kernel.dk> writes:
>>> /* Mapped buffer ring, return io_uring_buf from head */
>>> -#define io_ring_head_to_buf(br, head, mask) &(br)->bufs[(head) & (mask)]
>>> +#define io_ring_head_to_buf(br, head, mask) (&(br)->bufs[(head) & (mask)])
>>
>> Is there a reason this can't just be an inline function?
>
> And generally I don't like cleanups like this, but this one
> at least made sense to me.
The annoying part, IMO, is that we/I look at every trivial fix
wondering if it really is just a parenthesis fix, or if it's the next
CopyFail/Fragnesia fix with an obfuscated commit message..
ty
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2026-05-14 14:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 8:34 [PATCH] io_uring: parenthesize io_ring_head_to_buf() expansion Yi Xie
2026-05-14 13:24 ` Jens Axboe
2026-05-14 14:22 ` Caleb Sander Mateos
2026-05-14 14:25 ` Jens Axboe
2026-05-14 14:43 ` Caleb Sander Mateos
2026-05-14 14:44 ` Jens Axboe
2026-05-14 14:58 ` Gabriel Krisman Bertazi [this message]
2026-05-14 15:02 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a4u2597v.fsf@mailhost.krisman.be \
--to=krisman@suse.de \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=io-uring@vger.kernel.org \
--cc=xieyi@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.