From: John Ogness <john.ogness@linutronix.de>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Marcos Paulo de Souza <mpdesouza@suse.com>,
Chris Down <chris@chrisdown.name>,
linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH v2 1/9] printk: Rename struct console_cmdline to preferred_console
Date: Fri, 08 May 2026 16:28:29 +0206 [thread overview]
Message-ID: <87a4uaf0be.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <20260423130015.85175-2-pmladek@suse.com>
On 2026-04-23, Petr Mladek <pmladek@suse.com> wrote:
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index 0323149548f6..ca523acbf58d 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -2624,8 +2624,10 @@ __setup("console_msg_format=", console_msg_format_setup);
> */
> static int __init console_setup(char *str)
> {
> - static_assert(sizeof(console_cmdline[0].devname) >= sizeof(console_cmdline[0].name) + 4);
> - char buf[sizeof(console_cmdline[0].devname)];
> + static_assert(sizeof(preferred_consoles[0].devname) >=
> + sizeof(preferred_consoles[0].name) + 4);
> +
> + char buf[sizeof(preferred_consoles[0].devname)];
I agree with Steven's suggestion to move the static_assert() below the
local variable definitions.
Reviewed-by: John Ogness <john.ogness@linutronix.de>
next prev parent reply other threads:[~2026-05-08 14:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260423130015.85175-1-pmladek@suse.com>
[not found] ` <20260423130015.85175-4-pmladek@suse.com>
2026-05-05 17:47 ` [PATCH v2 3/9] printk: Separate code for adding/updating preferred console metadata Marcos Paulo de Souza
2026-05-15 10:23 ` John Ogness
2026-05-15 10:30 ` John Ogness
[not found] ` <20260423130015.85175-2-pmladek@suse.com>
2026-05-08 14:22 ` John Ogness [this message]
[not found] ` <20260423130015.85175-3-pmladek@suse.com>
2026-05-15 9:07 ` [PATCH v2 2/9] printk: Rename preferred_console to preferred_dev_console John Ogness
[not found] ` <20260423130015.85175-5-pmladek@suse.com>
2026-05-15 12:51 ` [PATCH v2 4/9] printk: Cleanup _braille_(un)register_console() wrappers John Ogness
[not found] ` <20260423130015.85175-6-pmladek@suse.com>
2026-05-05 17:56 ` [PATCH v2 5/9] printk: Separate code for enabling console Marcos Paulo de Souza
2026-05-15 12:57 ` John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a4uaf0be.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=chris@chrisdown.name \
--cc=linux-kernel@vger.kernel.org \
--cc=mpdesouza@suse.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.