From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CDBECD343F for ; Thu, 7 May 2026 16:45:37 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wL1qK-0003LG-Nj; Thu, 07 May 2026 12:44:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wL1qJ-0003KQ-Nb for qemu-arm@nongnu.org; Thu, 07 May 2026 12:44:55 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wL1qH-0000UX-Is for qemu-arm@nongnu.org; Thu, 07 May 2026 12:44:55 -0400 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-43fe3e22e33so735146f8f.0 for ; Thu, 07 May 2026 09:44:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778172291; x=1778777091; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CuiGuKD6lwcnZRJZhLkYNJ8PANSTQizjBrUnUtpF7LY=; b=DJdizwoopDqkKWVoqGFAXI1IIZDAhzZbdT4kLNd4gLriwkxzZIrCiqZUqawsKD7YBI cFpmh4A8pfX5ZtpNG8DI60OYn2s0VPy2X+5Y2RN/j0tkMeIEDPbfvzluWyistWm8YFJH gkVRwPpkRjTzlaq/OlxN50hARukZ0nb9r1cviqwsVSsosB/Rtq+o97Xzw4iCvHqJFnCV /4KEuXyLZp8uLbmxhgK2gytmZl8PdC1yx6j5qzjGlkhJdDSBdc5LUM/eHboHoSTvEEbl yISGrc42VCNn65YJCb16uOjYoIgGgtduYdQF3VPbP+BDZWXASRoNU88hFipLmANW+HaD AqdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778172291; x=1778777091; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CuiGuKD6lwcnZRJZhLkYNJ8PANSTQizjBrUnUtpF7LY=; b=kHh/ZDpUO6PG32jy3tXjTO/SIWa9DxdgsPZ+JWTMwMpi2ZIKa93PByQP3EFsSbpP2v 6NwoRJIheGQtVKlxLxZwlRB8jV5A6ZHvxxFwCe1nf91qk0UrzGSStGW2Bz95WzL0WxS6 iuzs6X+XA0HuRok8SXT4FjDKmRgUHthkMrMhQN4iWBzRkzxpGQhLTLWinS9XpEsE638Y Fs8U1ZfH2Gc+6vnEqVsoK3Cj5VjYWJ1f2Xqm1hYMk9SpCQ77JRO7k6KCqdzzqVsssyxt 8cHL/YOE1JLm1r1FlcREQLr265QLzQmKNBfSdH6oQ553kFysT4lM5XORzMBdwA49iU1+ Izcw== X-Forwarded-Encrypted: i=1; AFNElJ9AJoECjrzUpZ5hZCCfHjFUWLG2uEw4GSi9aEJTwNPzphu8IQ2vaDJlsGAQ4HpxFe6dRYiOO5JPxg==@nongnu.org X-Gm-Message-State: AOJu0Yw37lcThXWbuNwGuuNbef83EjR+y77N1YG7TPI0T65+37oiFj4V ObrcEz6JtxYK08tbjBOTlPnluVCaX8z8yCyxprbAUYizZOqHgZ/dcO8pxqg4EJ0y844= X-Gm-Gg: AeBDieu+hHTr4ZFu0m6JrW/gKYvBwSQAuD1UlBhk5IUCUyu4jkLPVgCwtNyB3sA/MLc 8fxLt/6wwbq2gKdHdj4SJwUjrq2Ety3A/aflsR7xbgbVlfNI0I+ZxbM8RtLda2D9yO/0AIDbShU FqxBv4z/BzL82jVFWB2NMrU3j5Ldk3wENNepfXTTjDsNfLFgGv5yQfOllPBQrfahHRSNkL4E1L0 7OqtDdm64a3FzsxJ5BDgpf6lHXq9AB0cGB7hlyKwt5iPtBbPWW5KbM1+Af3bG48R3gfTOULB11y PqNT3JLzu9li4fULp6Sf/sasonsfdJO82TFYp4BObu+F7aSJBQ7KBg6AME3Rlaf61cZj9jQEo8D oy0d/Zl8p6glMi4CWq3vw8trdgj37OjEs6Y4MN7RDzaLi0XFKeaoR0sAQ/RcQ2icq1S7iV8nSdw JzJXzdC16EXidA5T7ak1F6j8w= X-Received: by 2002:a05:6000:26c9:b0:44b:cb31:b767 with SMTP id ffacd0b85a97d-4515d2e6d77mr14460626f8f.36.1778172291300; Thu, 07 May 2026 09:44:51 -0700 (PDT) Received: from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-454177df883sm183623f8f.34.2026.05.07.09.44.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 09:44:50 -0700 (PDT) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 557195F83E; Thu, 07 May 2026 17:44:49 +0100 (BST) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Peter Maydell Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, Philippe =?utf-8?Q?Mathi?= =?utf-8?Q?eu-Daud=C3=A9?= , Marcel Apfelbaum , Yanan Wang , Zhao Liu , Paolo Bonzini , Richard Henderson , "Dr. David Alan Gilbert" , Alexandre Iooss , Mahmoud Mandour , Peter Xu , "Edgar E. Iglesias" , Jiaxun Yang , Nicholas Piggin , Chinmay Rath , Glenn Miles , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Chao Liu , Ilya Leoshkevich , David Hildenbrand , Mark Cave-Ayland , Artyom Tarasenko , Max Filippov Subject: Re: [PATCH v2 01/25] hw/i386/vapic: Cope with non-page-aligned return from cpu_get_phys_page_debug() In-Reply-To: <20260430093810.2762539-2-peter.maydell@linaro.org> (Peter Maydell's message of "Thu, 30 Apr 2026 10:37:46 +0100") References: <20260430093810.2762539-1-peter.maydell@linaro.org> <20260430093810.2762539-2-peter.maydell@linaro.org> User-Agent: mu4e 1.14.1; emacs 30.1 Date: Thu, 07 May 2026 17:44:49 +0100 Message-ID: <87a4ubkw3i.fsf@draig.linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Peter Maydell writes: > Currently the i386 implementation of get_phys_page_debug() always > returns an address aligned to a page boundary, and the vapic.c code > assumes this: it adds back in the page offset after the call. Change > this to OR in the page offset, so that it works whether > cpu_get_phys_page_debug() returns the page address or the exact > physical address. This will mean the code continues to work when > we change the semantics to standardize on "return exact > physical address". > > Signed-off-by: Peter Maydell Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro