From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D80F108E1E9 for ; Thu, 19 Mar 2026 11:21:02 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3BQq-00080p-Rb; Thu, 19 Mar 2026 07:20:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3BQp-00080J-D8 for qemu-trivial@nongnu.org; Thu, 19 Mar 2026 07:20:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3BQn-0006lD-Vq for qemu-trivial@nongnu.org; Thu, 19 Mar 2026 07:20:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773919249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cWZq5rCXRHJc6vx0NOQdqblmOCKa6Yl/CxCRqy9W7GI=; b=QMyWyG+WbTENXv0Kvq3fzZwdcSnIAA704FIC5ssiAhOEdd48CNrRQJBQJF0t2hP5ceAsQj Ixe2Un+86bJfdqNpsn5ynBlKriEvl06Mk583PTlWFMYt/lJp96vPVcY7aaXIZCsPcb07JO k7ZK3h/ACipG+u9Ko9458MG50aLX4E4= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-226-jw1F7pFxNpqFvk_OeF7d5w-1; Thu, 19 Mar 2026 07:20:47 -0400 X-MC-Unique: jw1F7pFxNpqFvk_OeF7d5w-1 X-Mimecast-MFC-AGG-ID: jw1F7pFxNpqFvk_OeF7d5w_1773919246 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E4F2719560B9; Thu, 19 Mar 2026 11:20:45 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9531C1955F25; Thu, 19 Mar 2026 11:20:45 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 1F05B21E6937; Thu, 19 Mar 2026 12:20:43 +0100 (CET) From: Markus Armbruster To: Thomas Huth Cc: Mark Cave-Ayland , qemu-devel@nongnu.org, qemu-trivial@nongnu.org, BALATON Zoltan Subject: Re: [PATCH] hw/display/cg3: Fix crash when introspecting cgthree from the CLI In-Reply-To: <20260317080623.438230-1-thuth@redhat.com> (Thomas Huth's message of "Tue, 17 Mar 2026 09:06:23 +0100") References: <20260317080623.438230-1-thuth@redhat.com> Date: Thu, 19 Mar 2026 12:20:43 +0100 Message-ID: <87a4w4awvo.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-MFC-PROC-ID: WQn1ivcsH9AMNVbiYZG8DTZBxg6-n_lQ-zDLi3yj9SQ_1773919246 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-trivial-bounces+qemu-trivial=archiver.kernel.org@nongnu.org Sender: qemu-trivial-bounces+qemu-trivial=archiver.kernel.org@nongnu.org Thomas Huth writes: > From: Thomas Huth > > QEMU currently crashes when introspecting the cgthree device from the > command line interface: > > $ ./qemu-system-sparc -device cgthree,help > Segmentation fault (core dumped) > > This happens because the memory_region_init_rom() function internally > calls qemu_ram_alloc_internal() that needs the current_machine pointer > to be set up - which is not the case here since the machine has not > been created yet. > > There does not seem to be a compelling reason for initializing the > memory regions from the instance_init function, so let's simply move > the code into the realize() function instead to fix this issue. > > Signed-off-by: Thomas Huth Tested-by: Markus Armbruster