From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F558CCFA0D for ; Thu, 6 Nov 2025 00:06:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 330F310E0F9; Thu, 6 Nov 2025 00:06:08 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="PDfUjZ2+"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1B31010E0F9 for ; Thu, 6 Nov 2025 00:06:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1762387566; x=1793923566; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=pquc+lp8ts/3xmWqnnE7XIJiAJewv9DWTZIIE+58UCM=; b=PDfUjZ2+bp2QkXiPuifTcHQlk2KSAzixTNB3gQ+CLNCmhP/MkucJg78Q udi62+wpdIt2EnwfmQqyD/3jLDl7JKZJ2eB9o3+NjBmRw0C/fwh/qEiZn RWUlJcYVelZCMNuXw/5HxfTC606ToGvEamPY6mi6MsBhJ1n11ROi7cBzg EA0akZ3gfdhWUbvTwCXBuKCv/gcUZdDWXgvyUZuEsr1NBeM7/Jk3piT/4 GjvDvYvGR4bUYX9qDZqjiiGcF7uXX5pM4M4U4N6rqtFUXtz3yO6lePgBb rxjbGMtPW3PWaWrMJz1dGS+kEvyDq4/KS8Mrzpti3E0nTOI6mT3eXVR+H w==; X-CSE-ConnectionGUID: vGFRsKZfRFOKwSDBP7OFrQ== X-CSE-MsgGUID: vmvfw+FBTay4D9tYIHBfWg== X-IronPort-AV: E=McAfee;i="6800,10657,11604"; a="64431943" X-IronPort-AV: E=Sophos;i="6.19,283,1754982000"; d="scan'208";a="64431943" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2025 16:05:56 -0800 X-CSE-ConnectionGUID: QSQlledtSfCMniBbwbpI5Q== X-CSE-MsgGUID: scCYVgIFTtSQ6a5OZ4Q/8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,283,1754982000"; d="scan'208";a="186851713" Received: from unknown (HELO adixit-MOBL3.intel.com) ([10.72.16.25]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2025 16:05:55 -0800 Date: Wed, 05 Nov 2025 16:05:54 -0800 Message-ID: <87a51058kd.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: intel-xe@lists.freedesktop.org, badal.nilawar@intel.com Subject: Re: [PATCH 0/4] Add SoC remapper support for system controller In-Reply-To: <20251105234753.603647-6-umesh.nerlige.ramappa@intel.com> References: <20251105234753.603647-6-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 05 Nov 2025 15:47:54 -0800, Umesh Nerlige Ramappa wrote: > > Add system controller configuration using SoC remapper for Xe3p. > > Signed-off-by: Umesh Nerlige Ramappa > > Umesh Nerlige Ramappa (4): > drm/xe/vsec: Refactor to move remapper logic outside vsec code > drm/xe/remapper: Add lock to serialize access to remapper index > registers > drm/xe/remapper: Add system controller index for remapper > drm/xe/remapper: Reprogram remapper index on PM resume events > > drivers/gpu/drm/xe/Makefile | 1 + > drivers/gpu/drm/xe/regs/xe_pmt.h | 3 -- > drivers/gpu/drm/xe/regs/xe_remapper_regs.h | 14 ++++++ > drivers/gpu/drm/xe/xe_device.c | 2 + > drivers/gpu/drm/xe/xe_device_types.h | 12 +++++ > drivers/gpu/drm/xe/xe_pm.c | 5 +++ > drivers/gpu/drm/xe/xe_remapper.c | 52 ++++++++++++++++++++++ > drivers/gpu/drm/xe/xe_remapper.h | 18 ++++++++ Drive by comment: Isn't xe_remapper* name too general? Maybe call the files xe_soc_remapper* or something like that? > drivers/gpu/drm/xe/xe_vsec.c | 5 +-- > 9 files changed, 106 insertions(+), 6 deletions(-) > create mode 100644 drivers/gpu/drm/xe/regs/xe_remapper_regs.h > create mode 100644 drivers/gpu/drm/xe/xe_remapper.c > create mode 100644 drivers/gpu/drm/xe/xe_remapper.h > > -- > 2.43.0 >