All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Tom Rini <trini@konsulko.com>, u-boot@lists.denx.de
Cc: Mattijs Korpershoek <mkorpershoek@kernel.org>,
	Igor Opaniuk <igor.opaniuk@gmail.com>,
	Sam Protsenko <semen.protsenko@linaro.org>
Subject: Re: [PATCH 2/2] common/avb_verify.c: Make use of LBAF for printing lbaint_t
Date: Wed, 02 Jul 2025 12:29:16 +0200	[thread overview]
Message-ID: <87a55mubr7.fsf@kernel.org> (raw)
In-Reply-To: <20250702010603.19354-2-trini@konsulko.com>

Hi Tom,

Thank you for the patch.

On Tue, Jul 01, 2025 at 19:06, Tom Rini <trini@konsulko.com> wrote:

> When printing the contents of an lbaint_t variable we need to use LBAF
> to print it in order to get the correct format type depending on 32 or
> 64bit-ness.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

> ---
> Cc: Mattijs Korpershoek <mkorpershoek@kernel.org>
> Cc: Igor Opaniuk <igor.opaniuk@gmail.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
>  common/avb_verify.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/common/avb_verify.c b/common/avb_verify.c
> index cff9117d92f1..29a3272579cf 100644
> --- a/common/avb_verify.c
> +++ b/common/avb_verify.c
> @@ -320,7 +320,7 @@ static unsigned long mmc_read_and_flush(struct mmc_part *part,
>  	}
>  	if ((start + sectors) > (part->info.start + part->info.size)) {
>  		sectors = part->info.start + part->info.size - start;
> -		printf("%s: read sector aligned to partition bounds (%ld)\n",
> +		printf("%s: read sector aligned to partition bounds (" LBAF ")\n",
>  		       __func__, sectors);
>  	}
>  
> @@ -363,7 +363,7 @@ static unsigned long mmc_write(struct mmc_part *part, lbaint_t start,
>  	}
>  	if ((start + sectors) > (part->info.start + part->info.size)) {
>  		sectors = part->info.start + part->info.size - start;
> -		printf("%s: sector aligned to partition bounds (%ld)\n",
> +		printf("%s: sector aligned to partition bounds (" LBAF ")\n",
>  		       __func__, sectors);
>  	}
>  	if (unaligned) {
> -- 
> 2.43.0

  reply	other threads:[~2025-07-02 10:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02  1:06 [PATCH 1/2] boot/android_ab.c: Make use of LBAF for printing lbaint_t Tom Rini
2025-07-02  1:06 ` [PATCH 2/2] common/avb_verify.c: " Tom Rini
2025-07-02 10:29   ` Mattijs Korpershoek [this message]
2025-07-03 16:01   ` Sam Protsenko
2025-07-02 10:27 ` [PATCH 1/2] boot/android_ab.c: " Mattijs Korpershoek
2025-07-03 16:00 ` Sam Protsenko
2025-07-09  8:03 ` Mattijs Korpershoek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a55mubr7.fsf@kernel.org \
    --to=mkorpershoek@kernel.org \
    --cc=igor.opaniuk@gmail.com \
    --cc=semen.protsenko@linaro.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.