From: Andreas Hindborg <a.hindborg@kernel.org>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>
Cc: "Abdiel Janulgue" <abdiel.janulgue@gmail.com>,
rust-for-linux@vger.kernel.org, daniel.almeida@collabora.com,
dakr@kernel.org, robin.murphy@arm.com, aliceryhl@google.com,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
=?utf-8?Q?Bj=C3=B6rn?= Roy Baron <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Trevor Gross" <tmgross@umich.edu>,
"Valentin Obst" <kernel@valentinobst.de>,
linux-kernel@vger.kernel.org, "Christoph Hellwig" <hch@lst.de>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
airlied@redhat.com, iommu@lists.linux.dev
Subject: Re: [PATCH v15 02/11] rust: add dma coherent allocator abstraction.
Date: Fri, 21 Mar 2025 07:56:13 +0100 [thread overview]
Message-ID: <87a59eeuwm.fsf@kernel.org> (raw)
In-Reply-To: <CANiq72k_2dknw9CWj=yxMeBBrvMjPp5mhu=H++BP_wTVCHtnew@mail.gmail.com> (Miguel Ojeda's message of "Fri, 21 Mar 2025 00:54:52 +0100")
"Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com> writes:
> On Tue, Mar 18, 2025 at 2:13 PM Andreas Hindborg <a.hindborg@kernel.org> wrote:
>>
>> The wording of in the other doc comments is different than this one and
>> the two next ones. Consider aligning them:
>>
>> Hints the DMA-mapping subsystem that ...
>>
>> Tells the DMA-mapping subsystem ...
>>
>> Indicates that the buffer ...
>
> These come from the C side and are copy-pasted, so I suspect that was
> the reason -- they may want to have them in sync, so I didn't touch
> them.
Since this particular doc discussion is about wording and not semantics,
I won't object too much. However, writing the docs for Rust is a very
good chance to get _better_ docs and in general I would encourage taking
advantage of that.
Best regards,
Andreas Hindborg
next prev parent reply other threads:[~2025-03-21 6:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <rTVBNBYxl4bn6nnkXBjTN8d-dpiCOR32i2Fpe5-wuhzcGjijW1iXnKaA4pbok32ockodVqTYGEfEA_JVpOC3ZQ==@protonmail.internalid>
2025-03-17 18:52 ` [PATCH v15 00/11] rust: add dma coherent allocator abstraction Abdiel Janulgue
2025-03-17 18:52 ` [PATCH v15 01/11] rust: error: Add EOVERFLOW Abdiel Janulgue
2025-03-17 18:52 ` [PATCH v15 02/11] rust: add dma coherent allocator abstraction Abdiel Janulgue
2025-03-18 13:07 ` Andreas Hindborg
2025-03-18 15:37 ` Alice Ryhl
2025-03-20 23:54 ` Miguel Ojeda
2025-03-21 6:56 ` Andreas Hindborg [this message]
2025-03-22 22:58 ` Daniel Almeida
2025-03-17 18:52 ` [PATCH v15 03/11] samples: rust: add Rust dma test sample driver Abdiel Janulgue
2025-03-18 13:06 ` Danilo Krummrich
2025-03-17 18:52 ` [PATCH v15 04/11] MAINTAINERS: add entry for Rust dma mapping helpers device driver API Abdiel Janulgue
2025-03-17 18:52 ` [PATCH v15 05/11] rust: dma: implement `dma::Device` trait Abdiel Janulgue
2025-03-17 18:52 ` [PATCH v15 06/11] rust: dma: add dma addressing capabilities Abdiel Janulgue
2025-03-17 18:52 ` [PATCH v15 07/11] rust: pci: implement the `dma::Device` trait Abdiel Janulgue
2025-03-17 18:52 ` [PATCH v15 08/11] rust: platform: " Abdiel Janulgue
2025-03-17 18:52 ` [PATCH v15 09/11] rust: dma: use `dma::Device` in `CoherentAllocation` Abdiel Janulgue
2025-06-03 12:18 ` Andreas Hindborg
2025-03-17 18:52 ` [PATCH v15 10/11] rust: samples: dma: set DMA mask Abdiel Janulgue
2025-03-17 18:52 ` [PATCH v15 11/11] rust: dma: add as_slice/write functions for CoherentAllocation Abdiel Janulgue
2025-03-18 14:09 ` Andreas Hindborg
2025-03-18 11:11 ` [PATCH v15 00/11] rust: add dma coherent allocator abstraction Danilo Krummrich
2025-03-18 14:11 ` Andreas Hindborg
2025-03-20 23:22 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a59eeuwm.fsf@kernel.org \
--to=a.hindborg@kernel.org \
--cc=abdiel.janulgue@gmail.com \
--cc=airlied@redhat.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=kernel@valentinobst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.