From: Jani Nikula <jani.nikula@linux.intel.com>
To: Yury Norov <yury.norov@gmail.com>, mailhol.vincent@wanadoo.fr
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
Andi Shyti <andi.shyti@linux.intel.com>,
David Laight <David.Laight@aculab.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v4 3/8] bits: introduce fixed-type genmasks
Date: Wed, 05 Mar 2025 17:52:56 +0200 [thread overview]
Message-ID: <87a59zxynb.fsf@intel.com> (raw)
In-Reply-To: <Z8hx9AaUX_GvYq_A@thinkpad>
On Wed, 05 Mar 2025, Yury Norov <yury.norov@gmail.com> wrote:
> On Wed, Mar 05, 2025 at 10:00:15PM +0900, Vincent Mailhol via B4 Relay wrote:
>> +#define GENMASK_U8(h, l) ((unsigned int)GENMASK_t(u8, h, l))
>> +#define GENMASK_U16(h, l) ((unsigned int)GENMASK_t(u16, h, l))
>
> Typecast to the type that user provides explicitly? And maybe do
> in GENMASK_TYPE()
The cast to unsigned int seemed odd to me too.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2025-03-05 15:53 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 13:00 [PATCH v4 0/8] bits: Fixed-type GENMASK()/BIT() Vincent Mailhol
2025-03-05 13:00 ` Vincent Mailhol via B4 Relay
2025-03-05 13:00 ` [PATCH v4 1/8] bits: fix typo 'unsigned __init128' -> 'unsigned __int128' Vincent Mailhol
2025-03-05 13:00 ` Vincent Mailhol via B4 Relay
2025-03-05 14:30 ` Yury Norov
2025-03-05 14:36 ` Andy Shevchenko
2025-03-05 14:38 ` Yury Norov
2025-03-05 16:09 ` Vincent Mailhol
2025-03-05 14:34 ` Andy Shevchenko
2025-03-05 13:00 ` [PATCH v4 2/8] bits: split the definition of the asm and non-asm GENMASK() Vincent Mailhol
2025-03-05 13:00 ` Vincent Mailhol via B4 Relay
2025-03-05 13:00 ` [PATCH v4 3/8] bits: introduce fixed-type genmasks Vincent Mailhol
2025-03-05 13:00 ` Vincent Mailhol via B4 Relay
2025-03-05 14:30 ` Andy Shevchenko
2025-03-05 14:38 ` Vincent Mailhol
2025-03-05 14:41 ` Andy Shevchenko
2025-03-06 14:48 ` Lucas De Marchi
2025-03-05 15:22 ` Yury Norov
2025-03-05 15:50 ` Andy Shevchenko
2025-03-19 1:46 ` Yury Norov
2025-03-19 3:34 ` Anshuman Khandual
2025-03-19 4:13 ` Anshuman Khandual
2025-03-21 17:05 ` Yury Norov
2025-03-22 11:46 ` Vincent Mailhol
2025-03-05 15:47 ` Yury Norov
2025-03-05 15:52 ` Jani Nikula [this message]
2025-03-05 16:48 ` Vincent Mailhol
2025-03-05 19:45 ` Andy Shevchenko
2025-03-06 9:22 ` Vincent Mailhol
2025-03-06 9:28 ` Andy Shevchenko
2025-03-05 13:00 ` [PATCH v4 4/8] bits: introduce fixed-type BIT Vincent Mailhol
2025-03-05 13:00 ` Vincent Mailhol via B4 Relay
2025-03-05 14:33 ` Andy Shevchenko
2025-03-05 14:48 ` Vincent Mailhol
2025-03-05 15:48 ` Andy Shevchenko
2025-03-05 17:17 ` Vincent Mailhol
2025-03-05 19:56 ` Andy Shevchenko
2025-03-05 21:50 ` David Laight
2025-03-06 8:12 ` Jani Nikula
2025-03-06 9:12 ` Andy Shevchenko
2025-03-06 9:38 ` Vincent Mailhol
2025-03-05 21:13 ` David Laight
2025-03-05 13:00 ` [PATCH v4 5/8] drm/i915: Convert REG_GENMASK* to fixed-width GENMASK_* Vincent Mailhol
2025-03-05 13:00 ` Vincent Mailhol via B4 Relay
2025-03-05 14:37 ` Andy Shevchenko
2025-03-05 13:00 ` [PATCH v4 6/8] test_bits: add tests for __GENMASK() and __GENMASK_ULL() Vincent Mailhol
2025-03-05 13:00 ` Vincent Mailhol via B4 Relay
2025-03-05 13:00 ` [PATCH v4 7/8] test_bits: add tests for fixed-type genmasks Vincent Mailhol
2025-03-05 13:00 ` Vincent Mailhol via B4 Relay
2025-03-05 13:00 ` [PATCH v4 8/8] test_bits: add tests for fixed-type BIT Vincent Mailhol
2025-03-05 13:00 ` Vincent Mailhol via B4 Relay
2025-03-05 15:59 ` [PATCH v4 0/8] bits: Fixed-type GENMASK()/BIT() Jani Nikula
2025-03-07 16:07 ` ✗ Fi.CI.CHECKPATCH: warning for bits: Fixed-type GENMASK()/BIT() (rev2) Patchwork
2025-03-07 16:07 ` ✗ Fi.CI.SPARSE: " Patchwork
2025-03-07 16:32 ` ✓ i915.CI.BAT: success " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2025-03-18 23:18 [PATCH v4 3/8] bits: introduce fixed-type genmasks kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a59zxynb.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=David.Laight@aculab.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andi.shyti@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lucas.demarchi@intel.com \
--cc=mailhol.vincent@wanadoo.fr \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=tursulin@ursulin.net \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.