Re: [PATCH v2 6/6] qdev: Improve a few more PropertyInfo @description members

[Markus Armbruster <armbru@redhat.com>]

Daniel P. Berrangé <berrange@redhat.com> writes:

> On Thu, Feb 27, 2025 at 09:56:01AM +0100, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  hw/block/xen-block.c             | 2 +-
>>  hw/core/qdev-properties-system.c | 2 +-
>>  hw/core/qdev-properties.c        | 1 +
>>  hw/s390x/ccw-device.c            | 4 ++--
>>  target/sparc/cpu.c               | 1 +
>>  5 files changed, 6 insertions(+), 4 deletions(-)
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
>
>> diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
>> index 5a801057db..c04df3b337 100644
>> --- a/hw/core/qdev-properties.c
>> +++ b/hw/core/qdev-properties.c
>> @@ -247,6 +247,7 @@ static void set_bool(Object *obj, Visitor *v, const char *name, void *opaque,
>>  
>>  const PropertyInfo qdev_prop_bool = {
>>      .type  = "bool",
>> +    .description = "on/off",
>
> Awkward as on/off for QemuOpts, but JSON true/false  for QMP, but I
> guess clarifying this is beyond the scope of the .description field.

In my view, description applies to human-friendly dotted-keys syntax,
not to JSON.  Trying to make it work for both would result in verbose
and confusing descriptions.

Thanks!