From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:504:4644:b0:1be9:327d:8ee3 with SMTP id d4csp788975njg; Wed, 26 Feb 2025 01:49:55 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUB+yME3djUTtPsPxCI0kITTVxBwsAqjYhq5PSvIFAsIdEEU5tPhvl2mahSFvDFYubtqPWVWplpiHyvxg==@linaro.org X-Google-Smtp-Source: AGHT+IFNVUA1LmRq9BmuhzN6xLOhj/Vy4jwZkWs76dvCzc1ONPUVDVH0/XjOWmTHPLADUIIcnIdf X-Received: by 2002:a05:620a:294f:b0:7b6:d8da:9095 with SMTP id af79cd13be357-7c247f20022mr400248985a.13.1740563394976; Wed, 26 Feb 2025 01:49:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1740563394; cv=none; d=google.com; s=arc-20240605; b=ErMj113erkorGrqaA+553jzJUDnS3TQhQhBItEgOO7eCZYfpI2cnuCdHeba1YKROoN 6fnaixWs/fTPADEPO/Z1McK5l2PC1jOjnmvLb8EVcMYniVSKpJo7WfpF06prUIKwflqD c6KNYDK+1Q6v2sM9De+p0X5jtl/dhz1cfxCdla3dqBOWh6mSR/sjOtODuud+iBxIGBlC X+GG7+0lE04kEaNxrQQMLkKadFA+Q3bym2Z4u6WbSZfPJHgWYIudXOAeqibP6akW9OyK uUYP8Ix2PUPtxWtYQPPXj2uhKDxHfPXswCHPbJOL2gT04+qMlEsKe2Kq5k8LhVu/fNPy rUPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version:user-agent :message-id:date:references:in-reply-to:subject:cc:to:from :dkim-signature; bh=qjMYlQITNoixhXNEiHlkCOqTz/eRJaGUmOufpNlVX5o=; fh=EbqKIRY0NKJCmiEA6itck7rE78l+4xj0ZHpXOhM4vho=; b=Yv19s2N+GvNPSm/S6let2hbR6qsvMA1eXX91IPqqB9HfAouhCZfMzlC+E/OjPRespb 0kRzo97n/TXr0GReJoyL1MH6rIhqe6/SP19lX+V5e3YmpoKiV8rqLf7av//Loaen7+ek K3gqRVIKkpfxi02lK1yweIKkOhe/ekwc3IMbmjEQvasJ8zv2vjE1k4tZA3baSyDekzGj FSGPcDROSvMZSinNDHnsM7DpDi0Gnv/KRu9JSD7yMWbCptmWuI6+qD+CROmPDdTJSVHm hbUrQuzBID222ya0fBwncG1K13bB+1MWzE8yVy/a9zufmuqkKRXsfa5xEHzHckBvrn53 vZWQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PUeIDoAq; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7c23c236286si325738185a.120.2025.02.26.01.49.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 Feb 2025 01:49:54 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PUeIDoAq; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tnE2t-0006lX-8x; Wed, 26 Feb 2025 04:49:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tnE2f-0006hJ-Jv for qemu-arm@nongnu.org; Wed, 26 Feb 2025 04:49:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tnE2d-0006eE-R8 for qemu-arm@nongnu.org; Wed, 26 Feb 2025 04:49:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740563360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qjMYlQITNoixhXNEiHlkCOqTz/eRJaGUmOufpNlVX5o=; b=PUeIDoAquXx4SuUHUAU6QS9Lx7nFW294GNh1zBfN6zmsMdWumjHVrMOnF57LtcEPKU1c4r wt3HSe57OV9z4YLUeOEBrE6ThkigmKA8uFZpQctvm/4dJ5vGEnTL120AJlgXGk9lr1GlbI ywWe9MJEF1Owe+0Z4vzarD6c+x5jlYY= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-enDWLv3yM2aZi-anRdoxhg-1; Wed, 26 Feb 2025 04:49:16 -0500 X-MC-Unique: enDWLv3yM2aZi-anRdoxhg-1 X-Mimecast-MFC-AGG-ID: enDWLv3yM2aZi-anRdoxhg_1740563354 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A8A041801A1B; Wed, 26 Feb 2025 09:49:14 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.9]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 49EFD19560AB; Wed, 26 Feb 2025 09:49:14 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id D18E421E675E; Wed, 26 Feb 2025 10:49:11 +0100 (CET) From: Markus Armbruster To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Eduardo Habkost , qemu-arm@nongnu.org, Ard Biesheuvel , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Thomas Huth , "Michael S. Tsirkin" , Marcel Apfelbaum , Peter Maydell , graf@amazon.com, Eric Blake , Michael Roth , Richard Henderson , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Paolo Bonzini Subject: Re: [PATCH v5 14/24] hw/uefi: add var-service-json.c + qapi for NV vars. In-Reply-To: (Gerd Hoffmann's message of "Wed, 26 Feb 2025 10:12:02 +0100") References: <20250225163031.1409078-1-kraxel@redhat.com> <20250225163031.1409078-15-kraxel@redhat.com> <87zfi95khl.fsf@pond.sub.org> <87bjup3y76.fsf@pond.sub.org> Date: Wed, 26 Feb 2025 10:49:11 +0100 Message-ID: <87a5a911ew.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.443, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: zccObfp/sqGA Gerd Hoffmann writes: >> >> > +# @digest: variable certificate digest. Used to verify the signature >> >> > +# of updates for authenticated variables. >> >> >> >> How to create and verify these digests will be obvious enough to users >> >> of this interface? >> > >> > Well, no. It's a somewhat complicated story ... > >> I wonder how much of this, if anything, should be worked into the doc >> comment. You decide :) > > A bit verbose for something rarely used. Tried to summarize it, > incremental update below: Looks good to me; Acked-by stands. Thanks!