From: Markus Armbruster <armbru@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Michael Roth" <michael.roth@amd.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"John Snow" <jsnow@redhat.com>
Subject: Re: [PATCH v4 3/4] qapi: rename 'special_features' to 'features'
Date: Fri, 07 Feb 2025 12:43:40 +0100 [thread overview]
Message-ID: <87a5ayj7yr.fsf@pond.sub.org> (raw)
In-Reply-To: <20250205123550.2754387-4-berrange@redhat.com> ("Daniel P. Berrangé"'s message of "Wed, 5 Feb 2025 12:35:49 +0000")
Daniel P. Berrangé <berrange@redhat.com> writes:
> This updates the QAPI code generation to refer to 'features' instead
> of 'special_features', in preparation for generalizing their exposure.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
John pointed out that isort wants the appended fixup. Not thrilled
about the additional churn, but let's not fight our tools. Thanks,
John!
diff --git a/scripts/qapi/types.py b/scripts/qapi/types.py
index ade6b7a3d7..e4a1bb9f85 100644
--- a/scripts/qapi/types.py
+++ b/scripts/qapi/types.py
@@ -16,11 +16,7 @@
from typing import List, Optional
from .common import c_enum_const, c_name, mcgen
-from .gen import (
- QAPISchemaModularCVisitor,
- gen_features,
- ifcontext,
-)
+from .gen import QAPISchemaModularCVisitor, gen_features, ifcontext
from .schema import (
QAPISchema,
QAPISchemaAlternatives,
diff --git a/scripts/qapi/visit.py b/scripts/qapi/visit.py
index 8dbf4ef1c3..928273b9bb 100644
--- a/scripts/qapi/visit.py
+++ b/scripts/qapi/visit.py
@@ -21,11 +21,7 @@
indent,
mcgen,
)
-from .gen import (
- QAPISchemaModularCVisitor,
- gen_features,
- ifcontext,
-)
+from .gen import QAPISchemaModularCVisitor, gen_features, ifcontext
from .schema import (
QAPISchema,
QAPISchemaAlternatives,
next prev parent reply other threads:[~2025-02-07 11:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 12:35 [PATCH v4 0/4] qapi: generalize special features Daniel P. Berrangé
2025-02-05 12:35 ` [PATCH v4 1/4] qapi: cope with feature names containing a '-' Daniel P. Berrangé
2025-02-05 12:35 ` [PATCH v4 2/4] qapi: change 'unsigned special_features' to 'uint64_t features' Daniel P. Berrangé
2025-02-05 12:35 ` [PATCH v4 3/4] qapi: rename 'special_features' to 'features' Daniel P. Berrangé
2025-02-07 11:43 ` Markus Armbruster [this message]
2025-02-05 12:35 ` [PATCH v4 4/4] qapi: expose all schema features to code Daniel P. Berrangé
2025-02-07 11:45 ` Markus Armbruster
2025-02-07 11:57 ` Markus Armbruster
2025-02-07 18:56 ` John Snow
2025-02-10 8:24 ` Markus Armbruster
2025-02-10 8:25 ` [PATCH v4 0/4] qapi: generalize special features Markus Armbruster
2025-02-10 8:37 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5ayj7yr.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=jsnow@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.