From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org,
Dmitry Antipov <dmantipov@yandex.ru>
Subject: Re: [PATCH] wifi: ath9k: do not submit zero bytes to the entropy pool
Date: Mon, 27 Jan 2025 14:21:53 +0100 [thread overview]
Message-ID: <87a5bcpf2m.fsf@toke.dk> (raw)
In-Reply-To: <20250123141058.1696502-1-dmantipov@yandex.ru>
Dmitry Antipov <dmantipov@yandex.ru> writes:
> In 'ath_cmn_process_fft()', it doesn't make too much sense to
> add zero bytes in attempt to improve randomness. So swap calls
> to 'memset()' and 'add_device_randomness()' to feed the pool
> with actual FFT results rather than zeroes. Compile tested only.
>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
This should probably have a Fixes tag:
Fixes: 2aa56cca3571 ("ath9k: Mix the received FFT bins to the random pool")
With that:
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
next prev parent reply other threads:[~2025-01-27 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 14:10 [PATCH] wifi: ath9k: do not submit zero bytes to the entropy pool Dmitry Antipov
2025-01-27 13:21 ` Toke Høiland-Jørgensen [this message]
2025-01-29 17:03 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5bcpf2m.fsf@toke.dk \
--to=toke@toke.dk \
--cc=dmantipov@yandex.ru \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.