All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Geoffrey D. Bennett" <g@b4.vu>
Cc: Takashi Iwai <tiwai@suse.de>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	linux-sound@vger.kernel.org
Subject: Re: [PATCH v7 1/2] ALSA: FCP: Add Focusrite Control Protocol driver
Date: Thu, 16 Jan 2025 17:48:54 +0100	[thread overview]
Message-ID: <87a5bqu2kp.wl-tiwai@suse.de> (raw)
In-Reply-To: <Z4k3M7S1Bo2EDlDO@m.b4.vu>

On Thu, 16 Jan 2025 17:43:31 +0100,
Geoffrey D. Bennett wrote:
> 
> Hi Takashi,
> 
> A couple of questions for clarification:
> 
> On Thu, Jan 16, 2025 at 04:03:48PM +0100, Takashi Iwai wrote:
> > On Thu, 16 Jan 2025 10:03:35 +0100,
> > Geoffrey D. Bennett wrote:
> [...]
> > > +#define SNDRV_CTL_TLVT_LABELS		0x110	/* channel labels */
> > 
> > IMHO, the data definition looks too ambiguous here to be put as a
> > public API.  It can be also a more specific name such as
> > *_CHANNEL_LABELS, too.
> 
> Do you mean e.g. SNDRV_CTL_TLVT_FCP_CHANNEL_LABELS ?
> 
> But still define in include/uapi/sound/tlv.h?
> 
> And 0x110 is okay to use?

All yes.


thanks,

Takashi

  reply	other threads:[~2025-01-16 16:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-16  9:02 [PATCH v7 0/2] ALSA: Add driver for big Scarlett 4th Gen interfaces Geoffrey D. Bennett
2025-01-16  9:03 ` [PATCH v7 1/2] ALSA: FCP: Add Focusrite Control Protocol driver Geoffrey D. Bennett
2025-01-16 15:03   ` Takashi Iwai
2025-01-16 16:43     ` Geoffrey D. Bennett
2025-01-16 16:48       ` Takashi Iwai [this message]
2025-01-16  9:03 ` [PATCH v7 2/2] ALSA: scarlett2: Add device_setup option to use FCP driver Geoffrey D. Bennett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5bqu2kp.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=g@b4.vu \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.