From: Kalle Valo <kvalo@kernel.org>
To: Alex Shumsky <alexthreed@gmail.com>
Cc: linux-wireless@vger.kernel.org, "Alexey Berezhok" <a@bayrepo.ru>,
"Alvin Šipraga" <ALSI@bang-olufsen.dk>,
"Arend van Spriel" <arend.vanspriel@broadcom.com>,
"Hector Martin" <marcan@marcan.st>, "Janne Grunau" <j@jannau.net>,
"Kees Cook" <kees@kernel.org>, "Neal Gompa" <neal@gompa.dev>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
brcm80211-dev-list.pdl@broadcom.com, brcm80211@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] brcmfmac: fix RSSI report in AP mode
Date: Mon, 25 Nov 2024 13:58:19 +0200 [thread overview]
Message-ID: <87a5dnv82s.fsf@kernel.org> (raw)
In-Reply-To: <20241122210346.2848578-1-alexthreed@gmail.com> (Alex Shumsky's message of "Sat, 23 Nov 2024 00:03:46 +0300")
Alex Shumsky <alexthreed@gmail.com> writes:
> After commit 9a1590934d9a ("brcmfmac: correctly report average RSSI in
> station info") it is required from firmware to provide rx_lastpkt_rssi.
> If this field is not provided brcmfmac doesn't report any RSSI at all.
> Unfortunately some firmwares doesn't provide it. One example is firmware
> for BCM43455 found in Raspbberry Pi.
> See https://github.com/raspberrypi/linux/issues/4574
>
> Fix it by falling back to rssi field if rx_lastpkt_rssi is not provided
> (like it was before 9a1590934d9a).
>
> Fixes: 9a1590934d9a ("brcmfmac: correctly report average RSSI in station info")
> Signed-off-by: Alex Shumsky <alexthreed@gmail.com>
'wifi:' missing but I can add it, no need to resend because of this.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-11-25 11:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 21:03 [PATCH] brcmfmac: fix RSSI report in AP mode Alex Shumsky
2024-11-25 11:58 ` Kalle Valo [this message]
2024-11-26 11:13 ` Arend van Spriel
2024-12-09 21:08 ` Alex Shumsky
2024-12-09 21:43 ` KeithG
2024-12-17 18:54 ` Alex Shumsky
2024-12-17 19:45 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5dnv82s.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ALSI@bang-olufsen.dk \
--cc=a@bayrepo.ru \
--cc=alexthreed@gmail.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=j@jannau.net \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=neal@gompa.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.