From: Andreas Hindborg <a.hindborg@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org
Subject: Re: [PATCH] block: return void from the queue_sysfs_entry load_module method
Date: Tue, 08 Oct 2024 10:36:08 +0200 [thread overview]
Message-ID: <87a5ffng93.fsf@kernel.org> (raw)
In-Reply-To: <20241008050841.104602-1-hch@lst.de> (Christoph Hellwig's message of "Tue, 8 Oct 2024 07:08:41 +0200")
Christoph Hellwig <hch@lst.de> writes:
> Requesting a module either succeeds or does nothing, return an error from
> this method does not make sense.
>
> Also move the load_module after the store method in the struct
> declaration to keep the important show and store methods together.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
Reviewed-by: Andreas Hindborg <a.hindborg@kernel.org>
next prev parent reply other threads:[~2024-10-08 8:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 5:08 [PATCH] block: return void from the queue_sysfs_entry load_module method Christoph Hellwig
2024-10-08 5:15 ` Damien Le Moal
2024-10-08 8:36 ` Andreas Hindborg [this message]
2024-10-08 13:28 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5ffng93.fsf@kernel.org \
--to=a.hindborg@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.