All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	Ping-Ke Shih <pkshih@realtek.com>
Subject: Re: [PATCH] wifi: rtlwifi: rtl8192du: Initialise value32 in _rtl92du_init_queue_reserved_page
Date: Tue, 06 Aug 2024 19:30:08 +0300	[thread overview]
Message-ID: <87a5hp62cv.fsf@kernel.org> (raw)
In-Reply-To: <2a808244-93d0-492c-b304-ae1974df5df9@gmail.com> (Bitterblue Smith's message of "Tue, 6 Aug 2024 19:20:11 +0300")

Bitterblue Smith <rtl8821cerfe2@gmail.com> writes:

> GCC complains:
>
>    In file included from include/linux/ieee80211.h:21,
>                     from include/net/mac80211.h:20,
>                     from drivers/net/wireless/realtek/rtlwifi/rtl8192du/../wifi.h:14,
>                     from drivers/net/wireless/realtek/rtlwifi/rtl8192du/hw.c:4:
>    In function 'u32p_replace_bits',
>        inlined from '_rtl92du_init_queue_reserved_page.isra' at drivers/net/wireless/realtek/rtlwifi/rtl8192du/hw.c:225:2:
>>> include/linux/bitfield.h:189:18: warning: 'value32' is used uninitialized [-Wuninitialized]
>
> Part of the variable is indeed left uninitialised.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202408062100.DWhN0CYH-lkp@intel.com/
> Fixes: e769c67105d3 ("wifi: rtlwifi: Add rtl8192du/hw.{c,h}")
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> ---
> Kalle and Ping-Ke,
>
> Kernel 6.11 will be the first one to include this driver.
> Should this patch go to the wireless tree?

Yes, compiler warning fixes should be always sent to Linus ASAP. Ping,
if you agree please assign the patch to me.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2024-08-06 16:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-06 16:20 [PATCH] wifi: rtlwifi: rtl8192du: Initialise value32 in _rtl92du_init_queue_reserved_page Bitterblue Smith
2024-08-06 16:30 ` Kalle Valo [this message]
2024-08-07  0:57   ` Ping-Ke Shih
2024-08-07 17:12 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5hp62cv.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    --cc=rtl8821cerfe2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.