From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Bennée Date: Wed, 31 Jul 2024 17:23:34 +0100 Subject: [PATCH v12 01/84] KVM: arm64: Release pfn, i.e. put page, if copying MTE tags hits ZONE_DEVICE In-Reply-To: <20240726235234.228822-2-seanjc@google.com> (Sean Christopherson's message of "Fri, 26 Jul 2024 16:51:10 -0700") References: <20240726235234.228822-1-seanjc@google.com> <20240726235234.228822-2-seanjc@google.com> Message-ID: <87a5hxfs3d.fsf@draig.linaro.org> List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sean Christopherson writes: > Put the page reference acquired by gfn_to_pfn_prot() if > kvm_vm_ioctl_mte_copy_tags() runs into ZONE_DEVICE memory. KVM's less- > than-stellar heuristics for dealing with pfn-mapped memory means that KVM > can get a page reference to ZONE_DEVICE memory. > > Fixes: f0376edb1ddc ("KVM: arm64: Add ioctl to fetch/store tags in a guest") > Signed-off-by: Sean Christopherson > --- > arch/arm64/kvm/guest.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c > index 11098eb7eb44..e1f0ff08836a 100644 > --- a/arch/arm64/kvm/guest.c > +++ b/arch/arm64/kvm/guest.c > @@ -1059,6 +1059,7 @@ int kvm_vm_ioctl_mte_copy_tags(struct kvm *kvm, > page = pfn_to_online_page(pfn); > if (!page) { > /* Reject ZONE_DEVICE memory */ > + kvm_release_pfn_clean(pfn); I guess this gets renamed later in the series. However my main comment is does lack of page always mean a ZONE_DEVICE? Looking at pfn_to_online_page() I see a bunch of other checks first. Why isn't it that functions responsibility to clean up after itself if its returning NULLs? > ret = -EFAULT; > goto out; > } -- Alex Benn?e Virtualisation Tech Lead @ Linaro From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3C611799F for ; Wed, 31 Jul 2024 16:23:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722443020; cv=none; b=k2+Rg/98bQhi6drsdjnD0Wg4MXVXnDjorAfDcKlLbKC3Lbyk6Zr9sPKDliI9Rup6uFx89kWRVUpbqTBrhAqTnk7nv48rXxieZE1zcryikQpmJYuS9Gzn2y79jsQHoSXqjco39QatL3a/rHDWQhG/VvinijZqmPCWkcW99N5RK1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722443020; c=relaxed/simple; bh=2HhUeVKAqujM6tGjz7xY7eoGDJF2k6V8JCfwVRNXp0M=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=MaaQSeSH4voP/75Rh5MvXepo6tTe//+vGVkClh/kk4wHXeW2CCWUC6SNdwIp28KhOnFp4aKG+PIIL/wjFZQn72FPTFuGW564wkpirPMrI3F3mU6FlxRElE3hyumEtmFCMkS/k53I1dpNj+rWyYoKXVV7O/ainbapxzR1XVmlKoA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GAA5B0xL; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GAA5B0xL" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a7aa086b077so529244566b.0 for ; Wed, 31 Jul 2024 09:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722443016; x=1723047816; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=/Jy3Eo6Gu+vhJFsd2nEOfkihTm91GOS2uDXcn/bR1Cs=; b=GAA5B0xLMxei9D/hOLh0U6AKzRakAwvFJRuUal+08LdYjBpP+Q51vdU1sCPm+AJVmH xJSAj8eVqZT/Hbo8OlQALRjAuyg0V7BSg/nLZamSmJLKsEUXQ183WCY+9NFI3Mpm2MFV Slk7sMauS0mXx+mi9lpt/sxRxoAu6Ks2Ale3hSDgsif1ucD/2CnjvTunFR9ZuhZ82znR yZAGtnEnaYZBVXShzEzr0LX/ZrskkslmHRBVcT3bG4AYGCso26pkqr0sHUr/DhF/d3cE oTzuex03bAxD8HMDC2DUwA7xuxdUgyhgR1wLS4V5nStJjH4+/hQfR8m6iaUY/9za2PBT wWMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722443016; x=1723047816; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Jy3Eo6Gu+vhJFsd2nEOfkihTm91GOS2uDXcn/bR1Cs=; b=MdzAKSLY+H52OwFVT58mrixwhcF9dX5zd77NO3CJx53kS98DYZt9LkMBNwXfsyzjBc RtWAvdXniULwUeXdfJBvpVfPchL8MrhjWNv0vzbvjSdWai0mJM/XCLmlbDlzzctIOYcV /RZnvbupvi71bfj+0iTxSiI6sFG5O+4hHGDL1ttLtWE5JfuEcttykEVmTVavHmDC0vnk /ZGucq6SUPoMgp8YLoJcKcZlGhe8qrym7+CuCkdZnpQCaPpNc7bTaBaDkr22Ro51xMnt eLpG19lfCZiyUPojEmMim+jJZkJqMArE2OlzFn6gIxui0rZx849jiQGApoV2u27YTWVZ 4MlQ== X-Forwarded-Encrypted: i=1; AJvYcCXTHfkgpfhUggDNXVQ4QcySs6pwbBjmqsg/3XPMkHBEXg2YiTsoZhO8lCs0/qoO0Mn6e6n/29HTPapg0Wr6Ue82jozI8rd0 X-Gm-Message-State: AOJu0YwV/Eyo0lZKNEsOOkYZxANvP2qS8STL5JGe+tozQ1vxMw+/1Ed8 BtnJWMZ0b907AlFkanLphRKMjKR9IyIVkI08JJpyIH26igWszv80t0xDEy1/VRE= X-Google-Smtp-Source: AGHT+IFaeuLsqXvHIvwNkMOmXQ/kk95KnaHAVzfZZFY2rJSwrdZANzuSfUeE19U50MBeGB1J/TbUHg== X-Received: by 2002:a17:907:a0d5:b0:a7a:b070:92c6 with SMTP id a640c23a62f3a-a7d40116a4bmr801926666b.50.1722443015967; Wed, 31 Jul 2024 09:23:35 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acad416basm784769266b.104.2024.07.31.09.23.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jul 2024 09:23:35 -0700 (PDT) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 614DC5F8CB; Wed, 31 Jul 2024 17:23:34 +0100 (BST) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , David Stevens Subject: Re: [PATCH v12 01/84] KVM: arm64: Release pfn, i.e. put page, if copying MTE tags hits ZONE_DEVICE In-Reply-To: <20240726235234.228822-2-seanjc@google.com> (Sean Christopherson's message of "Fri, 26 Jul 2024 16:51:10 -0700") References: <20240726235234.228822-1-seanjc@google.com> <20240726235234.228822-2-seanjc@google.com> Date: Wed, 31 Jul 2024 17:23:34 +0100 Message-ID: <87a5hxfs3d.fsf@draig.linaro.org> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sean Christopherson writes: > Put the page reference acquired by gfn_to_pfn_prot() if > kvm_vm_ioctl_mte_copy_tags() runs into ZONE_DEVICE memory. KVM's less- > than-stellar heuristics for dealing with pfn-mapped memory means that KVM > can get a page reference to ZONE_DEVICE memory. > > Fixes: f0376edb1ddc ("KVM: arm64: Add ioctl to fetch/store tags in a gues= t") > Signed-off-by: Sean Christopherson > --- > arch/arm64/kvm/guest.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c > index 11098eb7eb44..e1f0ff08836a 100644 > --- a/arch/arm64/kvm/guest.c > +++ b/arch/arm64/kvm/guest.c > @@ -1059,6 +1059,7 @@ int kvm_vm_ioctl_mte_copy_tags(struct kvm *kvm, > page =3D pfn_to_online_page(pfn); > if (!page) { > /* Reject ZONE_DEVICE memory */ > + kvm_release_pfn_clean(pfn); I guess this gets renamed later in the series. However my main comment is does lack of page always mean a ZONE_DEVICE? Looking at pfn_to_online_page() I see a bunch of other checks first. Why isn't it that functions responsibility to clean up after itself if its returning NULLs? > ret =3D -EFAULT; > goto out; > } --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72AA8C3DA7F for ; Wed, 31 Jul 2024 16:23:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JY0rjm7M2MzfAr8TzqDECs+K77v3mJ5ueVhOucBFnv0=; b=rrUHG9jrOwy/Gm 1XGjAT3iM3KL8TRh894M1myRoROochr2iK/1seyK2SDZUax2i1GLZlYU7evyHiUYxfrYoJgJI1zbc 2G52ZI8X3nt28/kPLbmnZW1Fx+zuWfcGhnmlC0J+koAMJtxPAKl9w9PoStd2tfzfA766hWRm6Qtx/ 7d6u5tHgx39Dcp17LZq26GAe+k4M+FkCDIvBCLOGaxcoYqU/rPaK3ig3p6iuYnSvm09IWFuWfbS3D dcnd7ukf7yFbjlIpkGD0/ATDNR7Lx7WZEj8TgX13DfvD4s3jhz2tLSIE23PsbdgPgIwogUQ7NE9Jl qPWkN8s5L0svgkHg96hg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZC74-00000001qsr-0bL8; Wed, 31 Jul 2024 16:23:42 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZC70-00000001qr6-0Xti for linux-riscv@lists.infradead.org; Wed, 31 Jul 2024 16:23:39 +0000 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a7a8553db90so813460666b.2 for ; Wed, 31 Jul 2024 09:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722443016; x=1723047816; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=/Jy3Eo6Gu+vhJFsd2nEOfkihTm91GOS2uDXcn/bR1Cs=; b=R9QSnkSqUXizd4+/F+zQQ7u+Q0IWE6VAvs4lEN1cIUZpaCf7c2Z2fjD4azVTUg7Gtw jGiVkicIKvtbxLIyFeQ3AFhWVXXpLam8K1iVwNUq2ahSyUPCAmtQvImleV3OEcROC8+J +CgyGTqk2RMgM1rbfilxXlgAwq+QwOUsLTQ7YcF0oYaM4BJHzbfebH9ceotBedPH0Dlu fNLgc/i4hA9ywcppOdUBi4FAAiqvWbotnV/StlVMdSL8bATwrY6T7k03m9GVawq5RZp5 7oXyJZBDODmFJVy0ZhmG4e1/7TrcZbkRzHuMZoPFBPfoKExipohN+x0IE91hLof4A61X qwUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722443016; x=1723047816; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Jy3Eo6Gu+vhJFsd2nEOfkihTm91GOS2uDXcn/bR1Cs=; b=qPUoPxzy6wEj4t+Z9iyIxitveSQLUi23JoYlYC+Ec5E6Jr9fpgxnbdl2m8de8iW0to 44tvRaJfsrSDQECs+qs+EVtFsAuq7HUSAD2Tb29/NB+mRz8QQbDSLha6sDLxD3eDXrDs OZY9yC3GZka1twMwMgTyHL0vQa7T9d7Sw703TqGwtAUcG1YDnzvaEQ2cs12wI/JqW4ji gj/ZYJWe4Q3MaswnMoNqsrrRdyGrxqh8GzC6X6YF/Dypi1Zd0YUH76KPkCM9kOsxvtFY mdO6Y3/uDzAO248/jARKhIYbSlQ00rc/LyUJLRzsJTa0tkrDeWXfGDY0hujpLZd57cGo MM0Q== X-Forwarded-Encrypted: i=1; AJvYcCVUhHk1IVDTQNNqfapxW+lswyFXohZhnqkezYsUyXcBts1PgQQZJ/KDaT99nMJ3TRsN1eC/0rEiVkzR+JsdPO2GG6Z/difSmsGjAOZRy1io X-Gm-Message-State: AOJu0Yz6JqtZ5nE7wdNqzbWP7Ifzw9mKKGKcA5ihA6qULTHXqdsKeT77 TMVSrbCvanWD4TNjgoi4QyCRQxOHsHrLnPKmEHgna8P1aXNcgByveM98NZB7O5A= X-Google-Smtp-Source: AGHT+IFaeuLsqXvHIvwNkMOmXQ/kk95KnaHAVzfZZFY2rJSwrdZANzuSfUeE19U50MBeGB1J/TbUHg== X-Received: by 2002:a17:907:a0d5:b0:a7a:b070:92c6 with SMTP id a640c23a62f3a-a7d40116a4bmr801926666b.50.1722443015967; Wed, 31 Jul 2024 09:23:35 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acad416basm784769266b.104.2024.07.31.09.23.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jul 2024 09:23:35 -0700 (PDT) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 614DC5F8CB; Wed, 31 Jul 2024 17:23:34 +0100 (BST) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , David Stevens Subject: Re: [PATCH v12 01/84] KVM: arm64: Release pfn, i.e. put page, if copying MTE tags hits ZONE_DEVICE In-Reply-To: <20240726235234.228822-2-seanjc@google.com> (Sean Christopherson's message of "Fri, 26 Jul 2024 16:51:10 -0700") References: <20240726235234.228822-1-seanjc@google.com> <20240726235234.228822-2-seanjc@google.com> Date: Wed, 31 Jul 2024 17:23:34 +0100 Message-ID: <87a5hxfs3d.fsf@draig.linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240731_092338_207288_F2CB4DA7 X-CRM114-Status: GOOD ( 14.26 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org U2VhbiBDaHJpc3RvcGhlcnNvbiA8c2VhbmpjQGdvb2dsZS5jb20+IHdyaXRlczoKCj4gUHV0IHRo ZSBwYWdlIHJlZmVyZW5jZSBhY3F1aXJlZCBieSBnZm5fdG9fcGZuX3Byb3QoKSBpZgo+IGt2bV92 bV9pb2N0bF9tdGVfY29weV90YWdzKCkgcnVucyBpbnRvIFpPTkVfREVWSUNFIG1lbW9yeS4gIEtW TSdzIGxlc3MtCj4gdGhhbi1zdGVsbGFyIGhldXJpc3RpY3MgZm9yIGRlYWxpbmcgd2l0aCBwZm4t bWFwcGVkIG1lbW9yeSBtZWFucyB0aGF0IEtWTQo+IGNhbiBnZXQgYSBwYWdlIHJlZmVyZW5jZSB0 byBaT05FX0RFVklDRSBtZW1vcnkuCj4KPiBGaXhlczogZjAzNzZlZGIxZGRjICgiS1ZNOiBhcm02 NDogQWRkIGlvY3RsIHRvIGZldGNoL3N0b3JlIHRhZ3MgaW4gYSBndWVzdCIpCj4gU2lnbmVkLW9m Zi1ieTogU2VhbiBDaHJpc3RvcGhlcnNvbiA8c2VhbmpjQGdvb2dsZS5jb20+Cj4gLS0tCj4gIGFy Y2gvYXJtNjQva3ZtL2d1ZXN0LmMgfCAxICsKPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9u KCspCj4KPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9rdm0vZ3Vlc3QuYyBiL2FyY2gvYXJtNjQv a3ZtL2d1ZXN0LmMKPiBpbmRleCAxMTA5OGViN2ViNDQuLmUxZjBmZjA4ODM2YSAxMDA2NDQKPiAt LS0gYS9hcmNoL2FybTY0L2t2bS9ndWVzdC5jCj4gKysrIGIvYXJjaC9hcm02NC9rdm0vZ3Vlc3Qu Ywo+IEBAIC0xMDU5LDYgKzEwNTksNyBAQCBpbnQga3ZtX3ZtX2lvY3RsX210ZV9jb3B5X3RhZ3Mo c3RydWN0IGt2bSAqa3ZtLAo+ICAJCXBhZ2UgPSBwZm5fdG9fb25saW5lX3BhZ2UocGZuKTsKPiAg CQlpZiAoIXBhZ2UpIHsKPiAgCQkJLyogUmVqZWN0IFpPTkVfREVWSUNFIG1lbW9yeSAqLwo+ICsJ CQlrdm1fcmVsZWFzZV9wZm5fY2xlYW4ocGZuKTsKCkkgZ3Vlc3MgdGhpcyBnZXRzIHJlbmFtZWQg bGF0ZXIgaW4gdGhlIHNlcmllcy4KCkhvd2V2ZXIgbXkgbWFpbiBjb21tZW50IGlzIGRvZXMgbGFj ayBvZiBwYWdlIGFsd2F5cyBtZWFuIGEgWk9ORV9ERVZJQ0U/Ckxvb2tpbmcgYXQgcGZuX3RvX29u bGluZV9wYWdlKCkgSSBzZWUgYSBidW5jaCBvZiBvdGhlciBjaGVja3MgZmlyc3QuIFdoeQppc24n dCBpdCB0aGF0IGZ1bmN0aW9ucyByZXNwb25zaWJpbGl0eSB0byBjbGVhbiB1cCBhZnRlciBpdHNl bGYgaWYgaXRzCnJldHVybmluZyBOVUxMcz8KCj4gIAkJCXJldCA9IC1FRkFVTFQ7Cj4gIAkJCWdv dG8gb3V0Owo+ICAJCX0KCi0tIApBbGV4IEJlbm7DqWUKVmlydHVhbGlzYXRpb24gVGVjaCBMZWFk IEAgTGluYXJvCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2 Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4685C3DA7F for ; Wed, 31 Jul 2024 16:24:27 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=V5Vx24jZ; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4WYy956cYbz3d2S for ; Thu, 1 Aug 2024 02:24:25 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=V5Vx24jZ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2a00:1450:4864:20::636; helo=mail-ej1-x636.google.com; envelope-from=alex.bennee@linaro.org; receiver=lists.ozlabs.org) Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4WYy8J6CHQz3cTl for ; Thu, 1 Aug 2024 02:23:42 +1000 (AEST) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a7a8553db90so813460466b.2 for ; Wed, 31 Jul 2024 09:23:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722443016; x=1723047816; darn=lists.ozlabs.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=/Jy3Eo6Gu+vhJFsd2nEOfkihTm91GOS2uDXcn/bR1Cs=; b=V5Vx24jZheWoC/LyeeQkxM6ju9KUI9WhRntBlcGefmGkyHN44NP/BF52tKIJF6XxaJ rz0hO1VV5Bkc0p0lZOFQXHXzDTQbUUWB7RIugQv3dvOlKLBfPNoTEmxfc3a5qgQ3XaN/ BicZKL79zMQswG+O5LuvCU/jjOS8IyJnk2cs02npp0S5SXJcKjc3vqsADPT43KoWkePz OJD2wQYK3mx/C7bhe6CfjeA9vu19KKsxPh1G3JIk+NSx4+9LIO0rT7IRrWRMzTI9/tN/ SR1KxE0ZVtMbPJYLQGBcHHNygYTZy/qAHMoS3S4QfQ0F1Yh5wUYl7IqrhFiU1ZaRPzFO mCVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722443016; x=1723047816; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Jy3Eo6Gu+vhJFsd2nEOfkihTm91GOS2uDXcn/bR1Cs=; b=f/OjslPYd4VBDPHGxMPzXzmSxDPeeqCd48dNDulbw7OrST/6S/aeb3RxEwaz3UJh89 y5bhxfggsO7B3Km9SG0ri55r0O0heWiOjZmEQT7Y45AcmXdIPBCjfTbFgtOnxHJNX5PY uwmuQBCjeZRFVo3WgmaCWDdPUL6E1VOg7a9nKLw56gdQWbtlin0iAFEwKJNjkitbzwbo nkw2mUBfEaBkCgxYrbkWZmdOkBvszdUk4AhRwcyXJTtQe6ezmT7YYno+aJIlRBz0hdiy 7PRUzbaDt4zD88johVTunKNKupluO06A74TLrMybUZBogSJ7Av0XWl+XhMgIZ/4pp1GV j32A== X-Forwarded-Encrypted: i=1; AJvYcCVuDSkVOyfZ5bHv5sgOVHUdCDr5RbQtb4lRamh/OUuTCtJdBhXjNhL3Bn7FGtKgCDMQp2HJZRsdLjFWcBGDrAz8ZtWDfCHikwjeLERjxg== X-Gm-Message-State: AOJu0YznywBxSDD9CQZLS4mxxcc5ij/JBUYfyjxUiIVPra8dCaebsoAx y5AiWz8sHwDTqMXmbl17ty1dqzPe+Cf+pMdnPjlA8/59C9Uk5htNU+RUpIf2NcE= X-Google-Smtp-Source: AGHT+IFaeuLsqXvHIvwNkMOmXQ/kk95KnaHAVzfZZFY2rJSwrdZANzuSfUeE19U50MBeGB1J/TbUHg== X-Received: by 2002:a17:907:a0d5:b0:a7a:b070:92c6 with SMTP id a640c23a62f3a-a7d40116a4bmr801926666b.50.1722443015967; Wed, 31 Jul 2024 09:23:35 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acad416basm784769266b.104.2024.07.31.09.23.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jul 2024 09:23:35 -0700 (PDT) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 614DC5F8CB; Wed, 31 Jul 2024 17:23:34 +0100 (BST) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Sean Christopherson Subject: Re: [PATCH v12 01/84] KVM: arm64: Release pfn, i.e. put page, if copying MTE tags hits ZONE_DEVICE In-Reply-To: <20240726235234.228822-2-seanjc@google.com> (Sean Christopherson's message of "Fri, 26 Jul 2024 16:51:10 -0700") References: <20240726235234.228822-1-seanjc@google.com> <20240726235234.228822-2-seanjc@google.com> Date: Wed, 31 Jul 2024 17:23:34 +0100 Message-ID: <87a5hxfs3d.fsf@draig.linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, David Matlack , linux-riscv@lists.infradead.org, Claudio Imbrenda , Janosch Frank , Marc Zyngier , Huacai Chen , Christian Borntraeger , Albert Ou , Bibo Mao , loongarch@lists.linux.dev, Paul Walmsley , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, Oliver Upton , Palmer Dabbelt , David Stevens , kvm-riscv@lists.infradead.org, Anup Patel , Paolo Bonzini , Tianrui Zhao , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Sean Christopherson writes: > Put the page reference acquired by gfn_to_pfn_prot() if > kvm_vm_ioctl_mte_copy_tags() runs into ZONE_DEVICE memory. KVM's less- > than-stellar heuristics for dealing with pfn-mapped memory means that KVM > can get a page reference to ZONE_DEVICE memory. > > Fixes: f0376edb1ddc ("KVM: arm64: Add ioctl to fetch/store tags in a gues= t") > Signed-off-by: Sean Christopherson > --- > arch/arm64/kvm/guest.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c > index 11098eb7eb44..e1f0ff08836a 100644 > --- a/arch/arm64/kvm/guest.c > +++ b/arch/arm64/kvm/guest.c > @@ -1059,6 +1059,7 @@ int kvm_vm_ioctl_mte_copy_tags(struct kvm *kvm, > page =3D pfn_to_online_page(pfn); > if (!page) { > /* Reject ZONE_DEVICE memory */ > + kvm_release_pfn_clean(pfn); I guess this gets renamed later in the series. However my main comment is does lack of page always mean a ZONE_DEVICE? Looking at pfn_to_online_page() I see a bunch of other checks first. Why isn't it that functions responsibility to clean up after itself if its returning NULLs? > ret =3D -EFAULT; > goto out; > } --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro