From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8298CD128A for ; Mon, 8 Apr 2024 09:00:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B23BC112312; Mon, 8 Apr 2024 09:00:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ldAfodDe"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 649D211230A for ; Mon, 8 Apr 2024 09:00:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712566813; x=1744102813; h=from:to:subject:in-reply-to:references:date:message-id: mime-version; bh=OApAM7gHetZoouA51QgkSDBhGpafpL6BKVnGbDIvrHc=; b=ldAfodDeZXW43v9vR/H69g8H4vLErikCrAugQo/+9p9fGmV4EpfptZ9z aDtjipeD4kdh7h4UwKyUdApECxrO0Gd9jJOjlbFIXHhOioPxmFmP6Fb78 b/Eossazn0FSEq8DESHpaT/uCoHi3OEmhS9ox6EFT/C0tIm5aCrNMySTY yjGRIzhOTupnEY8FTcaFpeuid2aeIg44TFt063Z5hlbmwkCWrGmvGaln7 ddmBONQHmB5NeyaweD780SmP/qEapwSq2PQzQkabew584umndxf2//qbt ua7o0QNogxtm6eaQUpxS+INps74nVMSNfpXbNZp2Nf82QKkSYfxsbNJpU g==; X-CSE-ConnectionGUID: zUv2DjjYR4SRKp/ua8vGZg== X-CSE-MsgGUID: C2QNQ5p+Q86he6ZINe1Xsg== X-IronPort-AV: E=McAfee;i="6600,9927,11037"; a="7698586" X-IronPort-AV: E=Sophos;i="6.07,186,1708416000"; d="scan'208";a="7698586" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 02:00:12 -0700 X-CSE-ConnectionGUID: YNlnGHMnQ8G8vlcR1vibgw== X-CSE-MsgGUID: EqlAMSJrScylZpAnbhjUSQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,186,1708416000"; d="scan'208";a="50804656" Received: from bauinger-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.42.71]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 02:00:11 -0700 From: Jani Nikula To: dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/edid: make drm_edid_are_equal() static In-Reply-To: <20240314112620.1728394-1-jani.nikula@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240314112620.1728394-1-jani.nikula@intel.com> Date: Mon, 08 Apr 2024 12:00:07 +0300 Message-ID: <87a5m4b560.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 14 Mar 2024, Jani Nikula wrote: > drm_edid_are_equal() is only used within drm_edid.c. Make it static. Do > not encourage more uses of struct edid. Resent as part of https://patchwork.freedesktop.org/series/132142/ > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid.c | 3 +-- > include/drm/drm_edid.h | 2 -- > 2 files changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 923c4423151c..4c4e0d161490 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -1818,7 +1818,7 @@ static bool edid_block_is_zero(const void *edid) > * This helper can be used during probing to determine if > * edid had changed. > */ > -bool drm_edid_are_equal(const struct edid *edid1, const struct edid *edid2) > +static bool drm_edid_are_equal(const struct edid *edid1, const struct edid *edid2) > { > int edid1_len, edid2_len; > bool edid1_present = edid1 != NULL; > @@ -1840,7 +1840,6 @@ bool drm_edid_are_equal(const struct edid *edid1, const struct edid *edid2) > > return true; > } > -EXPORT_SYMBOL(drm_edid_are_equal); > > enum edid_block_status { > EDID_BLOCK_OK = 0, > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > index 7923bc00dc7a..b3f01f388ea8 100644 > --- a/include/drm/drm_edid.h > +++ b/include/drm/drm_edid.h > @@ -327,8 +327,6 @@ int drm_edid_to_speaker_allocation(const struct edid *edid, u8 **sadb); > int drm_av_sync_delay(struct drm_connector *connector, > const struct drm_display_mode *mode); > > -bool drm_edid_are_equal(const struct edid *edid1, const struct edid *edid2); > - > int > drm_hdmi_avi_infoframe_from_display_mode(struct hdmi_avi_infoframe *frame, > const struct drm_connector *connector, -- Jani Nikula, Intel