From: Thomas Gleixner <tglx@linutronix.de>
To: Bibo Mao <maobibo@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Sergey Shtylyov <s.shtylyov@omp.ru>,
lvjianmin@loongson.cn
Subject: Re: [PATCH v5 3/3] irqchip/loongson-eiointc: Refine irq affinity setting during resume
Date: Tue, 13 Feb 2024 10:49:23 +0100 [thread overview]
Message-ID: <87a5o4iti4.ffs@tglx> (raw)
In-Reply-To: <20240130082722.2912576-4-maobibo@loongson.cn>
On Tue, Jan 30 2024 at 16:27, Bibo Mao wrote:
> During suspend and resume, CPUs except CPU0 can be hot-unpluged and IRQs
> will be migrated to CPU0. So it is not necessary to restore irq affinity
> for eiointc irq controller when system resumes.
That's not the reason. The point is that eiointc_router_init() which is
invoked in the resume path affines all interrupts to CPU0, so the
restore operation is redundant, no?
> This patch removes this piece of code about irq affinity restoring in
> function eiointc_resume().
Again. 'This patch' is pointless because we already know that this is a
patch, no?
next prev parent reply other threads:[~2024-02-13 9:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 8:27 [PATCH v5 0/3] irqchip/loongson-eiointc: Refine irq affinity setting during resume Bibo Mao
2024-01-30 8:27 ` [PATCH v5 1/3] irqchip/loongson-eiointc: Typo fix in function eiointc_domain_alloc Bibo Mao
2024-02-13 8:46 ` Thomas Gleixner
2024-02-13 9:31 ` [tip: irq/urgent] irqchip/loongson-eiointc: Use correct struct type in eiointc_domain_alloc() tip-bot2 for Bibo Mao
2024-01-30 8:27 ` [PATCH v5 2/3] irqchip/loongson-eiointc: Skip handling if there is no pending irq Bibo Mao
2024-02-13 9:57 ` [tip: irq/core] irqchip/loongson-eiointc: Skip handling if there is no pending interrupt tip-bot2 for Bibo Mao
2024-01-30 8:27 ` [PATCH v5 3/3] irqchip/loongson-eiointc: Refine irq affinity setting during resume Bibo Mao
2024-02-13 9:49 ` Thomas Gleixner [this message]
2024-02-17 3:32 ` maobibo
2024-03-13 6:20 ` Huacai Chen
2024-03-13 12:39 ` Thomas Gleixner
2024-03-14 14:34 ` Huacai Chen
2024-02-13 9:56 ` [tip: irq/core] irqchip/loongson-eiointc: Remove explicit interrupt affinity restore on resume tip-bot2 for Bibo Mao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5o4iti4.ffs@tglx \
--to=tglx@linutronix.de \
--cc=chenhuacai@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lvjianmin@loongson.cn \
--cc=maobibo@loongson.cn \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.