All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Jean-Loïc Charroud" <lagiraudiere+linux@free.fr>
Cc: Takashi Iwai <tiwai@suse.de>,
	Stefan Binding <sbinding@opensource.cirrus.com>,
	Jaroslav Kysela <perex@perex.cz>,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	linux-sound <linux-sound@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	patches <patches@opensource.cirrus.com>
Subject: Re: [PATCH] ALSA: hda/realtek: cs35l41: Fix device ID / model name
Date: Wed, 07 Feb 2024 18:10:58 +0100	[thread overview]
Message-ID: <87a5oc5hel.wl-tiwai@suse.de> (raw)
In-Reply-To: <1618884269.586462178.1707324711030.JavaMail.zimbra@free.fr>

On Wed, 07 Feb 2024 17:51:51 +0100,
Jean-Loïc Charroud wrote:
> 
> (un)swap device ID for "ASUS UM3402" and "ASUS UM6702RA/RC".

You need to explain why it's needed.  Was it wrongly done?  Or for
what purpose you swap?

And, here you need to give "Fixes:" tag pointing to the commit that
introduced the change / line.  In this case, it was 51d976079976
("ALSA: hda/realtek: Add quirks for ASUS Zenbook 2022 Models").
It modified the entry 1043:1e2e from "ASUS UM3402" to "ASUS
UM6702RA/RC" and add another entry for "ASUS UM3402" with 104e:1ee2.


thanks,

Takashi

  reply	other threads:[~2024-02-07 17:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-06 17:05 [PATCH v2] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD Jean-Loïc Charroud
2024-02-07 13:42 ` Takashi Iwai
2024-02-07 14:30   ` Jean-Loïc Charroud
2024-02-07 15:10     ` Takashi Iwai
2024-02-07 16:45       ` Jean-Loïc Charroud
2024-02-07 16:51       ` [PATCH] ALSA: hda/realtek: cs35l41: Fix device ID / model name Jean-Loïc Charroud
2024-02-07 17:10         ` Takashi Iwai [this message]
2024-02-07 18:05           ` Jean-Loïc Charroud
2024-02-07 17:48       ` [PATCH v2] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD Jean-Loïc Charroud
2024-02-07 18:13         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5oc5hel.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=lagiraudiere+linux@free.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=rf@opensource.cirrus.com \
    --cc=sbinding@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.