From: Peter Korsgaard <peter@korsgaard.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Guillaume William Brs <guillaume.bressaix@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3,1/1] package/liquid-dsp: fix x86 builds
Date: Sat, 13 Jan 2024 14:27:02 +0100 [thread overview]
Message-ID: <87a5p9uzx5.fsf@48ers.dk> (raw)
In-Reply-To: <20240108211420.360412-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Mon, 8 Jan 2024 22:14:20 +0100")
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> HAVE_{MMX,SSE2,...} are not defined if ax_cv_have_{i}_cpu_ext is not set
> resulting in the following build failure raised since bump to version
> 1.5.0 in commit c2aaa0fbe2fdf6e599c68169aa7b2e55237190c7 and
> https://github.com/jgaeddert/liquid-dsp/commit/02c4e8b99b11d9f1615b8840f243b08a85b86563:
> src/dotprod/src/dotprod_cccf.sse.c: In function 'dotprod_cccf_execute_sse':
> src/dotprod/src/dotprod_cccf.sse.c:258:5: error: unknown type name '__m128'; did you mean '__int128'?
> 258 | __m128 v; // input vector
> | ^~~~~~
> | __int128
> or
> src/dotprod/src/dotprod_cccf.mmx.c: In function 'dotprod_cccf_execute_mmx':
> src/dotprod/src/dotprod_cccf.mmx.c:262:5: error: unknown type name '__m128'; did you mean '__int128'?
> 262 | __m128 v; // input vector
> | ^~~~~~
> | __int128
> While at it, add AVX2 support
> Fixes:
> - http://autobuild.buildroot.org/results/738ce9d3dc74ec165391f21256c955e5524f1632
> - http://autobuild.buildroot.org/results/a2d150c724ab6787aeabaf31f65116f802e8584e
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v2 -> v3 (after review of Yann E. Morin):
> - Keep current list format
> Changes v1 -> v2:
> - Keep old options (mmx, etc.) as they seem to be still used somewhere
> in the code
Committed to 2023.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-01-13 13:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 21:14 [Buildroot] [PATCH v3,1/1] package/liquid-dsp: fix x86 builds Fabrice Fontaine
2024-01-08 22:10 ` Yann E. MORIN
2024-01-13 13:27 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5p9uzx5.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=guillaume.bressaix@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.