From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Grzegorz Szymaszek <gszymaszek@short.pl>, u-boot@lists.denx.de
Cc: Grzegorz Szymaszek <gszymaszek@short.pl>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Maxim Cournoyer <maxim.cournoyer@gmail.com>,
Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH] doc: fix three-dash references in reStructuredText
Date: Tue, 09 Jan 2024 15:50:56 +0100 [thread overview]
Message-ID: <87a5pewofj.fsf@baylibre.com> (raw)
In-Reply-To: <ZZktRm3O89FnozlD@nx64de-df6d00>
Hi Grzegorz,
Thank you for the patch.
On sam., janv. 06, 2024 at 11:36, Grzegorz Szymaszek <gszymaszek@short.pl> wrote:
> The "Sending patches" and "Patman patch manager" documents refer to the
> three-dash, "---", that separates patch parts. The symbol is written in
> the documentation in the same form as it is in actual patches: as three
> U+002D HYPHEN-MINUS characters. When building the documentation, Sphinx
> converts this symbol to a U+2014 EM DASH, that is invalid in this case.
>
> Make the three-dash symbol a reStructuredText inline literal to prevent
> its conversion; that is, enclose it in a pair of double backquotes (`).
>
> Signed-off-by: Grzegorz Szymaszek <gszymaszek@short.pl>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
> doc/develop/sending_patches.rst | 4 ++--
> tools/patman/patman.rst | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/doc/develop/sending_patches.rst b/doc/develop/sending_patches.rst
> index 5a6962f102..3f25b1d046 100644
> --- a/doc/develop/sending_patches.rst
> +++ b/doc/develop/sending_patches.rst
> @@ -121,7 +121,7 @@ General Patch Submission Rules
> * For new features: a description of the feature and your implementation.
>
> * Additional comments which you don't want included in U-Boot's history can be
> - included below the first "---" in the message body.
> + included below the first "``---``" in the message body.
>
> * If your description gets too long, that's a strong indication that you should
> split up your patch.
> @@ -253,7 +253,7 @@ to observe the following rules.
>
> * Please make sure to keep a "change log", i.e. a description of what you have
> changed compared to previous versions of this patch. This change log should
> - be added below the "---" line in the patch, which starts the "comment
> + be added below the "``---``" line in the patch, which starts the "comment
> section", i.e. which contains text that does not get included into the
> actual commit message.
> Note: it is *not* sufficient to provide a change log in some cover letter
> diff --git a/tools/patman/patman.rst b/tools/patman/patman.rst
> index a8b317eed6..e01355824c 100644
> --- a/tools/patman/patman.rst
> +++ b/tools/patman/patman.rst
> @@ -280,7 +280,7 @@ Series-notes:
>
> Commit-notes:
> Similar, but for a single commit (patch). These notes will appear
> - immediately below the --- cut in the patch file::
> + immediately below the ``---`` cut in the patch file::
>
> Commit-notes:
> blah blah
> --
> 2.43.0
prev parent reply other threads:[~2024-01-09 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-06 10:36 [PATCH] doc: fix three-dash references in reStructuredText Grzegorz Szymaszek
2024-01-09 14:50 ` Mattijs Korpershoek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5pewofj.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=gszymaszek@short.pl \
--cc=maxim.cournoyer@gmail.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.